Merge lp:~fgimenez/snappy/activate-test into lp:~snappy-dev/snappy/snappy-moved-to-github

[Federico Gimenez]

Activate test

Activate test

[Leo Arias (elopio)]

cool. Just please rename it to basic-binaries so I can add my failed bin.
Also take a look from my branch of the constants I moved to the data.go. If you like it you can do that here, or I'll update your const on my branch once yours lands.

Here's an idea: Lets make a snaps cache, so we have to build them only once. I'll make a card.

About:

+func (s *activateSuite) TestSnapIsInstalled(c *check.C) {

I'm not sure. Do we need it? common.InstallSnap(c, s.snapPath) would fail if something is wrong, and we already have a test to check that list shows the installed snaps.

review: Needs Fixing

[Federico Gimenez (fgimenez)]

> cool. Just please rename it to basic-binaries so I can add my failed bin.
> Also take a look from my branch of the constants I moved to the data.go. If
> you like it you can do that here, or I'll update your const on my branch once
> yours lands.

Ok, feel free to move it there.

>
> Here's an idea: Lets make a snaps cache, so we have to build them only once.
> I'll make a card.

Awesome! That will make test writing easier and execution quicker :)

>
> About:
>
> +func (s *activateSuite) TestSnapIsInstalled(c *check.C) {
>
> I'm not sure. Do we need it? common.InstallSnap(c, s.snapPath) would fail if
> something is wrong, and we already have a test to check that list shows the
> installed snaps.

The main point of this test was just to make sure that the snap is listed by snappy list -v with a trailing "*". Anyway, it feels like a "nothing in my pockets, nothing up my sleeves" thing :) i'll remove it.

Thanks!

[lp:~fgimenez/snappy/activate-test]

748. By Federico Gimenez on 2015-10-09

renamed snap; removed TestSnapIsInstalled

749. By Federico Gimenez on 2015-10-09

added new snap

750. By Federico Gimenez on 2015-10-09

fixed snap name

[Leo Arias (elopio)]

review: Approve

=== added directory '_integration-tests/data/snaps/basic-binaries'
=== added directory '_integration-tests/data/snaps/basic-binaries/bin'
=== added file '_integration-tests/data/snaps/basic-binaries/bin/echo'
--- _integration-tests/data/snaps/basic-binaries/bin/echo	1970-01-01 00:00:00 +0000
+++ _integration-tests/data/snaps/basic-binaries/bin/echo	2015-10-09 07:49:28 +0000
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+echo "From basic-binaries snap"

=== added directory '_integration-tests/data/snaps/basic-binaries/meta'
=== added file '_integration-tests/data/snaps/basic-binaries/meta/package.yaml'
--- _integration-tests/data/snaps/basic-binaries/meta/package.yaml	1970-01-01 00:00:00 +0000
+++ _integration-tests/data/snaps/basic-binaries/meta/package.yaml	2015-10-09 07:49:28 +0000
@@ -0,0 +1,6 @@
+name: basic-binaries
+version: 1.0
+vendor: Snappy Developers <[e-mail]>
+icon: meta/snappy64.png
+binaries:
+ - name: bin/echo

=== added file '_integration-tests/data/snaps/basic-binaries/meta/readme.md'
--- _integration-tests/data/snaps/basic-binaries/meta/readme.md	1970-01-01 00:00:00 +0000
+++ _integration-tests/data/snaps/basic-binaries/meta/readme.md	2015-10-09 07:49:28 +0000
@@ -0,0 +1,3 @@
+Basic Binary snap
+
+A basic snap with binary entries

=== added file '_integration-tests/data/snaps/basic-binaries/meta/snappy64.png'
Binary files _integration-tests/data/snaps/basic-binaries/meta/snappy64.png	1970-01-01 00:00:00 +0000 and _integration-tests/data/snaps/basic-binaries/meta/snappy64.png	2015-10-09 07:49:28 +0000 differ
=== added file '_integration-tests/tests/activate_test.go'
--- _integration-tests/tests/activate_test.go	1970-01-01 00:00:00 +0000
+++ _integration-tests/tests/activate_test.go	2015-10-09 07:49:28 +0000
@@ -0,0 +1,84 @@
+// -*- Mode: Go; indent-tabs-mode: t -*-
+
+/*
+ * Copyright (C) 2015 Canonical Ltd
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+package tests
+
+import (
+	"os"
+
+	"gopkg.in/check.v1"
+
+	"launchpad.net/snappy/_integration-tests/testutils/build"
+	"launchpad.net/snappy/_integration-tests/testutils/cli"
+	"launchpad.net/snappy/_integration-tests/testutils/common"
+)
+
+const (
+	activateSnapName    = "basic-binaries"
+	activateBinName     = activateSnapName + ".echo"
+	activateEchoOutput  = "From basic-binaries snap\n"
+	baseActivatePattern = "(?msU).*" + activateSnapName + `\s*.*\s*.*sideload`
+	activatedPattern    = baseActivatePattern + `\*\s*\n.*`
+	deActivatedPattern  = baseActivatePattern + `\s*\n.*`
+)
+
+var _ = check.Suite(&activateSuite{})
+
+type activateSuite struct {
+	common.SnappySuite
+	snapPath string
+}
+
+func (s *activateSuite) SetUpSuite(c *check.C) {
+	s.SnappySuite.SetUpSuite(c)
+	var err error
+	s.snapPath, err = build.LocalSnap(c, activateSnapName)
+	c.Assert(err, check.IsNil)
+	common.InstallSnap(c, s.snapPath)
+}
+
+func (s *activateSuite) TearDownSuite(c *check.C) {
+	os.Remove(s.snapPath)
+	common.RemoveSnap(c, activateSnapName)
+}
+
+func (s *activateSuite) TestDeactivateRemovesBinary(c *check.C) {
+	cli.ExecCommand(c, "sudo", "snappy", "deactivate", activateSnapName)
+	defer cli.ExecCommand(c, "sudo", "snappy", "activate", activateSnapName)
+	output, err := cli.ExecCommandErr(activateBinName)
+
+	c.Assert(err, check.NotNil)
+	c.Assert(output, check.Not(check.Equals), activateEchoOutput)
+
+	list := cli.ExecCommand(c, "snappy", "list", "-v")
+
+	c.Assert(list, check.Matches, deActivatedPattern)
+}
+
+func (s *activateSuite) TestActivateBringsBinaryBack(c *check.C) {
+	cli.ExecCommand(c, "sudo", "snappy", "deactivate", activateSnapName)
+	cli.ExecCommand(c, "sudo", "snappy", "activate", activateSnapName)
+	output := cli.ExecCommand(c, activateBinName)
+
+	c.Assert(output, check.Equals, activateEchoOutput)
+
+	list := cli.ExecCommand(c, "snappy", "list", "-v")
+
+	c.Assert(list, check.Matches, activatedPattern)
+}