Code review comment for lp:~fgimenez/snapcraft/build-examples-test

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Thanks, this is a good start, looping over everything in examples will do the initial trick. In the future I will split this out a bit and use something a bit more custom for each checking if stage and snap have the right set of files for example.

The reason I set to needs fixing though is because of 'run_examples_tests.sh', it seems there is too much duplicate code here and in runtests.sh, it also introduces one more driver for them.

I'd like to see this at least driven by an envvar or command arg

./runtests.sh all (default)
./runtests.sh unit
./runtest.sh plainbox
./runtest.sh plainbox examples|normal

Thoughts?

review: Needs Fixing

« Back to merge proposal