Code review comment for lp:~fgiff/linaro-android-bot-review/884390

Revision history for this message
Frans Gifford (fgiff) wrote :

> Just a note - in exception handling context (in "except:" suite), you can use
> log.exception("message") to make it log message and associated exception stack
> trace. Unless you of course want to suppress stack trace logging, then using
> log.error() is the way to go. I don't think the distinction is critical here,
> so looks ok, thanks.

I didn't about log.exception, which is why I used log.error instead. We can change it later if necessary.

« Back to merge proposal