Merge lp:~fgiff/linaro-android-bot-review/884390 into lp:linaro-android-bot-review
Proposed by
Frans Gifford
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Frans Gifford | ||||
Approved revision: | 77 | ||||
Merged at revision: | 77 | ||||
Proposed branch: | lp:~fgiff/linaro-android-bot-review/884390 | ||||
Merge into: | lp:linaro-android-bot-review | ||||
Diff against target: |
128 lines (+21/-21) 3 files modified
gerritconnection.py (+10/-10) jenkinsconnection.py (+5/-5) lavaconnection.py (+6/-6) |
||||
To merge this branch: | bzr merge lp:~fgiff/linaro-android-bot-review/884390 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Sokolovsky | Approve | ||
Review via email:
|
To post a comment you must log in.
Just a note - in exception handling context (in "except:" suite), you can use log.exception( "message" ) to make it log message and associated exception stack trace. Unless you of course want to suppress stack trace logging, then using log.error() is the way to go. I don't think the distinction is critical here, so looks ok, thanks.