Great work Fabio!
Really nice to see the document viewer catching up.
I've reviewed the branch and I've suggested a few changes inline. Additionally, there are a couple of other things I'd like to ask to change:
1. On the debian/control file, could you add the following, just like [1]?
override_dh_auto_configure: + dh_auto_configure -- -DCLICK_MODE=OFF
2. On the manifest.json file:
+ "architecture": "@CLICK_ARCH@",
+ "apparmor": "docviewer.apparmor",
3. Then 'bzr rename ubuntu-docviewer-app.json docviewer.apparmor'
Do you think you could address these points, commit the changes and do a new push to the same branch? Once you do the push, the merge proposal will update automatically for you.
[1] https://code.launchpad.net/~zeller-benjamin/ubuntu-terminal-app/sdkcompat/+merge/233747
« Back to merge proposal
Great work Fabio!
Really nice to see the document viewer catching up.
I've reviewed the branch and I've suggested a few changes inline. Additionally, there are a couple of other things I'd like to ask to change:
1. On the debian/control file, could you add the following, just like [1]?
override_ dh_auto_ configure:
+ dh_auto_configure -- -DCLICK_MODE=OFF
2. On the manifest.json file:
+ "architecture": "@CLICK_ARCH@",
+ "apparmor": "docviewer. apparmor" ,
3. Then 'bzr rename ubuntu- docviewer- app.json docviewer.apparmor'
Do you think you could address these points, commit the changes and do a new push to the same branch? Once you do the push, the merge proposal will update automatically for you.
[1] https:/ /code.launchpad .net/~zeller- benjamin/ ubuntu- terminal- app/sdkcompat/ +merge/ 233747