Merge lp:~fcole90/ubuntu-docviewer-app/ubuntu-docviewer-app into lp:ubuntu-docviewer-app/trunk

Proposed by fcole90
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 55
Merged at revision: 29
Proposed branch: lp:~fcole90/ubuntu-docviewer-app/ubuntu-docviewer-app
Merge into: lp:ubuntu-docviewer-app/trunk
Diff against target: 332 lines (+144/-66)
16 files modified
CMakeLists.txt (+77/-0)
debian/control (+14/-9)
debian/rules (+3/-0)
debian/ubuntu-docviewer-app-autopilot.install (+1/-1)
debian/ubuntu-docviewer-app.install (+3/-4)
docviewer-app.in (+3/-0)
docviewer.apparmor (+2/-3)
manifest.json (+2/-1)
tests/CMakeLists.txt (+1/-0)
tests/autopilot/CMakeLists.txt (+10/-0)
tests/autopilot/ubuntu_docviewer_app/CMakeLists.txt (+9/-0)
tests/autopilot/ubuntu_docviewer_app/tests/CMakeLists.txt (+6/-0)
tests/autopilot/ubuntu_docviewer_app/tests/__init__.py (+1/-1)
ubuntu-docviewer-app.desktop (+0/-12)
ubuntu-docviewer-app.desktop.in.in (+12/-0)
ubuntu-docviewer-app.qmlproject (+0/-35)
To merge this branch: bzr merge lp:~fcole90/ubuntu-docviewer-app/ubuntu-docviewer-app
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
fcole90 Needs Information
David Planella Needs Fixing
Review via email: mp+234438@code.launchpad.net

Commit message

Removed qmlproject and added proper CMakeLists to enable the development with cmake. Also removed the desktop file which is now created by cmake from a desktop.in.in file.

Description of the change

Removed qmlproject and added proper CMakeLists to enable the development with cmake. Also removed the desktop file which is now created by cmake from a desktop.in.in file.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:31
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~fcole90/ubuntu-docviewer-app/ubuntu-docviewer-app/+merge/234438/+edit-commit-message

http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/39/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1979/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-docviewer-app-utopic-amd64-ci/11/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-docviewer-app-ci/39/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

Great work Fabio!

Really nice to see the document viewer catching up.

I've reviewed the branch and I've suggested a few changes inline. Additionally, there are a couple of other things I'd like to ask to change:

1. On the debian/control file, could you add the following, just like [1]?

override_dh_auto_configure:
 + dh_auto_configure -- -DCLICK_MODE=OFF

2. On the manifest.json file:

+ "architecture": "@CLICK_ARCH@",

+ "apparmor": "docviewer.apparmor",

3. Then 'bzr rename ubuntu-docviewer-app.json docviewer.apparmor'

Do you think you could address these points, commit the changes and do a new push to the same branch? Once you do the push, the merge proposal will update automatically for you.

[1] https://code.launchpad.net/~zeller-benjamin/ubuntu-terminal-app/sdkcompat/+merge/233747

review: Needs Fixing
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
fcole90 (fcole90) wrote :

I've added the changes that you asked me. There are still some problems with the new cmake configuration, I hope to fix them soon.

Revision history for this message
fcole90 (fcole90) wrote :

David, can you help me? What does the following mean?
---
Not attempting to fix packaging branch ancestry, missing pristine tar data for version 0.1.1.
Contents conflict in ubuntu-docviewer-app.qmlproject
1 conflicts encountered.
bzr: ERROR: Conflicts from merge
---

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

This is due to trunk having changes made in a file after you branched which you have also changed. As you are removing the file (ubuntu-docviewer-app.qmlproject) you can just ignore the conflict.

$ bzr merge lp:ubuntu-docviewer-app
$ bzr resolve ubuntu-docviewer-app.qmlproject
$ bzr commit -m "Merge of trunk"

And then push that back up, more info can be found here [0] about merge conflicts.

0 - http://doc.bazaar.canonical.com/beta/en/user-guide/resolving_conflicts.html

Revision history for this message
fcole90 (fcole90) wrote :

Thank you, hope that works now :)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
fcole90 (fcole90) wrote :

I think that I need to add cmake as a dependence

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
fcole90 (fcole90) wrote :

I'm sorry, I just noticed the inline comments :/

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

This needs some debian packaging love. I would suggest pinging dholbach for help.

Revision history for this message
fcole90 (fcole90) wrote :

Thank you. I'm building some culture about debian packaging, but tomorrow I'm going to follow your suggestion ;)

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Fabio, Daniel graciously fixed things up -- have a look at his mp and merge it into your branch for this:

https://code.launchpad.net/~dholbach/ubuntu-docviewer-app/packaging-fixes/+merge/235001

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
fcole90 (fcole90) wrote :

I wish to thank you all for the help, I would have spent a century trying to fix that :)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
fcole90 (fcole90) wrote :

What's happening? Is the autolanding based on python3?

review: Needs Information
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Fabio, we didn't sneak in on time before the jenkins job got updated :(. I was trying to keep your mp a bit simpler.

So, Yep, remember those changes I asked you to 'undo' for python3? We need them now :-) Can you convert this to python3 again and push?

52. By fcole90

Upgraded to python 3

Revision history for this message
fcole90 (fcole90) wrote :

Just done ;)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
fcole90 (fcole90) wrote :

The jourey continues. We need to update the autopilot tests to python3, because ATM they seem to not work. @Nicholas: can you confirm? :)

53. By fcole90

migrating tests to python3

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
54. By fcole90

Make the tests follow the python* environment

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

rev 54 is really weird Fabio. I would leave things @ rev 53. The __init__.py has other changes we can and will do to bring it in line with the other apps. Let's push this for now and start on it.

55. By fcole90

Reverted to 53

Revision history for this message
fcole90 (fcole90) wrote :

That's a strange effect. Anyway, just reverted ;-)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'CMakeLists.txt'
2--- CMakeLists.txt 1970-01-01 00:00:00 +0000
3+++ CMakeLists.txt 2014-09-18 18:07:33 +0000
4@@ -0,0 +1,77 @@
5+project(com.ubuntu.docviewer)
6+cmake_minimum_required(VERSION 2.8.9)
7+find_program(INTLTOOL_MERGE intltool-merge)
8+find_program(INTLTOOL_EXTRACT intltool-extract)
9+
10+# Standard install paths
11+include(GNUInstallDirs)
12+
13+option(INSTALL_TESTS "Install the tests on make install" on)
14+option(CLICK_MODE "Installs to a contained location" on)
15+
16+set(APP_NAME docviewer)
17+set(DESKTOP_FILE "ubuntu-docviewer-app.desktop")
18+#set(URLS_FILE "${PROJECT_NAME}_${APP_NAME}.url-dispatcher")
19+set(MAIN_QML ubuntu-docviewer-app.qml)
20+set(ICON_FILE docviewer@30.png)
21+set(AUTOPILOT_DIR ubuntu_docviewer_app)
22+set(APP_HARDCODE docviewer-app)
23+set(UBUNTU_MANIFEST_PATH "manifest.json" CACHE INTERNAL "Relative path to the manifest file")
24+
25+if(CLICK_MODE)
26+ if(NOT DEFINED BZR_SOURCE)
27+ set(BZR_SOURCE "lp:ubuntu-${APP_HARDCODE}")
28+ message("-- Setting BZR_SOURCE to ${BZR_SOURCE}")
29+ endif(NOT DEFINED BZR_SOURCE)
30+ set(CMAKE_INSTALL_PREFIX /)
31+ set(CMAKE_INSTALL_BINDIR /)
32+ set(DATA_DIR /)
33+ set (ICON ${ICON_FILE})
34+ set(EXEC "qmlscene %u ${MAIN_QML}")
35+ set(DESKTOP_DIR ${DATA_DIR})
36+ set(URLS_DIR ${DATA_DIR})
37+else(CLICK_MODE)
38+ set(DATA_DIR ${CMAKE_INSTALL_DATADIR}/ubuntu-${APP_HARDCODE})
39+ set(EXEC ${APP_HARDCODE})
40+ set(ICON ${CMAKE_INSTALL_PREFIX}/${DATA_DIR}/${ICON_FILE})
41+ configure_file(${APP_HARDCODE}.in
42+ ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE})
43+ install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE}
44+ DESTINATION ${CMAKE_INSTALL_BINDIR})
45+ set(DESKTOP_DIR ${CMAKE_INSTALL_DATADIR}/applications)
46+ set(URLS_DIR ${CMAKE_INSTALL_DATADIR}/url-dispatcher/urls)
47+endif(CLICK_MODE)
48+
49+file(GLOB_RECURSE I18N_SRC_FILES
50+ RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}/po
51+ *.qml *.js)
52+list(APPEND I18N_SRC_FILES ${DESKTOP_FILE}.in.in.h)
53+list(SORT I18N_SRC_FILES)
54+message("Found ${I18N_SRC_FILES}")
55+
56+file(GLOB SRC_FILES
57+ RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}
58+ *.qml *.js)
59+add_custom_target(ubuntu-docviewer-app_QMlFiles ALL SOURCES ${SRC_FILES})
60+
61+file(GLOB RESOURCE_FILES
62+ RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}
63+ *.png *.svg)
64+install(FILES ${SRC_FILES} ${RESOURCE_FILES} ${ICON_FILE} DESTINATION ${DATA_DIR})
65+
66+configure_file(${DESKTOP_FILE}.in.in ${DESKTOP_FILE}.in)
67+
68+add_custom_target(${DESKTOP_FILE} ALL
69+ COMMENT "Merging translations into ${DESKTOP_FILE}"
70+ COMMAND LC_ALL=C ${INTLTOOL_MERGE} -d -u ${CMAKE_SOURCE_DIR}/po ${DESKTOP_FILE}.in ${DESKTOP_FILE} >/dev/null
71+)
72+
73+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE} DESTINATION ${DESKTOP_DIR})
74+
75+#install(FILES ${URLS_FILE} DESTINATION ${URLS_DIR})
76+
77+# Tests
78+enable_testing()
79+
80+
81+add_subdirectory(tests)
82
83=== modified file 'debian/control'
84--- debian/control 2013-10-05 22:31:30 +0000
85+++ debian/control 2014-09-18 18:07:33 +0000
86@@ -1,23 +1,27 @@
87 Source: ubuntu-docviewer-app
88 Priority: extra
89 Maintainer: Ubuntu App Cats <ubuntu-touch-coreapps@lists.launchpad.net>
90-Build-Depends: debhelper (>= 9),
91- qt5-default,
92- qtdeclarative5-dev
93+Build-Depends: cmake,
94+ debhelper (>= 9),
95+ intltool,
96+ python3,
97+ qt5-default,
98+ qtdeclarative5-dev-tools,
99+ qtdeclarative5-qtquick2-plugin,
100+ qtdeclarative5-test-plugin
101 Standards-Version: 3.9.4
102 Section: misc
103 Homepage: https://launchpad.net/ubuntu-docviewer-app
104 Vcs-Bzr: https://code.launchpad.net/~ubuntu-docviewer-dev/ubuntu-docviewer-app/trunk
105
106 Package: ubuntu-docviewer-app
107-Section: misc
108 Architecture: any
109-Depends: ${misc:Depends},
110+Depends: file-qml-plugin,
111 qmlscene,
112+ qtdeclarative5-poppler-qml-plugin,
113+ qtdeclarative5-qtquick2-plugin,
114 qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
115- qtdeclarative5-qtquick2-plugin,
116- qtdeclarative5-poppler-qml-plugin,
117- file-qml-plugin
118+ ${misc:Depends}
119 Description: Document Viewer application
120 Core Document Viewer application
121
122@@ -25,7 +29,8 @@
123 Architecture: all
124 Depends: libautopilot-qt,
125 libqt5test5,
126- ubuntu-docviewer-app (= ${source:Version}),
127+ ubuntu-docviewer-app (>= ${source:Version}),
128 ubuntu-ui-toolkit-autopilot,
129+ ${misc:Depends}
130 Description: Autopilot tests for Document Viewer Application
131 This package contains the autopilot tests for the Document Viewer
132
133=== modified file 'debian/rules'
134--- debian/rules 2013-04-11 20:58:07 +0000
135+++ debian/rules 2014-09-18 18:07:33 +0000
136@@ -7,5 +7,8 @@
137 %:
138 dh $@
139
140+override_dh_auto_configure:
141+ dh_auto_configure -- -DCLICK_MODE=OFF
142+
143 override_dh_install:
144 dh_install --fail-missing
145
146=== modified file 'debian/ubuntu-docviewer-app-autopilot.install'
147--- debian/ubuntu-docviewer-app-autopilot.install 2013-05-31 12:25:45 +0000
148+++ debian/ubuntu-docviewer-app-autopilot.install 2014-09-18 18:07:33 +0000
149@@ -1,1 +1,1 @@
150-tests/autopilot/ubuntu_docviewer_app/* usr/lib/python2.7/dist-packages/ubuntu_docviewer_app/
151+usr/lib/*/dist-packages/ubuntu_docviewer_app/*
152
153=== modified file 'debian/ubuntu-docviewer-app.install'
154--- debian/ubuntu-docviewer-app.install 2013-09-26 14:01:54 +0000
155+++ debian/ubuntu-docviewer-app.install 2014-09-18 18:07:33 +0000
156@@ -1,4 +1,3 @@
157-ubuntu-docviewer-app.desktop usr/share/applications/
158-*.qml usr/share/ubuntu-docviewer-app/
159-*.png usr/share/ubuntu-docviewer-app/
160-*.js usr/share/ubuntu-docviewer-app/
161+usr/share/ubuntu-docviewer-app
162+usr/share/applications
163+usr/bin/docviewer-app
164
165=== added file 'docviewer-app.in'
166--- docviewer-app.in 1970-01-01 00:00:00 +0000
167+++ docviewer-app.in 2014-09-18 18:07:33 +0000
168@@ -0,0 +1,3 @@
169+#!/bin/sh
170+export QT_SELECT=qt5
171+exec qmlscene @CMAKE_INSTALL_PREFIX@/@DATA_DIR@/@MAIN_QML@
172
173=== renamed file 'ubuntu-docviewer-app.json' => 'docviewer.apparmor'
174--- ubuntu-docviewer-app.json 2014-03-13 18:11:54 +0000
175+++ docviewer.apparmor 2014-09-18 18:07:33 +0000
176@@ -1,5 +1,4 @@
177 {
178- "policy_groups": [
179- ],
180- "policy_version": 1
181+ "policy_groups": [],
182+ "policy_version": 1.2
183 }
184
185=== modified file 'manifest.json'
186--- manifest.json 2013-10-14 16:50:23 +0000
187+++ manifest.json 2014-09-18 18:07:33 +0000
188@@ -1,9 +1,10 @@
189 {
190 "description": "Document Viewer application for Ubuntu devices",
191 "framework": "ubuntu-sdk-13.10",
192+ "architecture": "@CLICK_ARCH@",
193 "hooks": {
194 "ubuntu-docviewer-app": {
195- "apparmor": "ubuntu-docviewer-app.json",
196+ "apparmor": "docviewer.apparmor",
197 "desktop": "ubuntu-docviewer-app.desktop"
198 }
199 },
200
201=== added file 'tests/CMakeLists.txt'
202--- tests/CMakeLists.txt 1970-01-01 00:00:00 +0000
203+++ tests/CMakeLists.txt 2014-09-18 18:07:33 +0000
204@@ -0,0 +1,1 @@
205+add_subdirectory(autopilot)
206
207=== added file 'tests/autopilot/CMakeLists.txt'
208--- tests/autopilot/CMakeLists.txt 1970-01-01 00:00:00 +0000
209+++ tests/autopilot/CMakeLists.txt 2014-09-18 18:07:33 +0000
210@@ -0,0 +1,10 @@
211+if(INSTALL_TESTS)
212+execute_process(COMMAND python3 -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
213+ OUTPUT_VARIABLE PYTHON_PACKAGE_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)
214+
215+install(DIRECTORY ${AUTOPILOT_DIR}
216+ DESTINATION ${PYTHON_PACKAGE_DIR}
217+ )
218+endif(INSTALL_TESTS)
219+
220+add_subdirectory(ubuntu_docviewer_app)
221
222=== added file 'tests/autopilot/ubuntu_docviewer_app/CMakeLists.txt'
223--- tests/autopilot/ubuntu_docviewer_app/CMakeLists.txt 1970-01-01 00:00:00 +0000
224+++ tests/autopilot/ubuntu_docviewer_app/CMakeLists.txt 2014-09-18 18:07:33 +0000
225@@ -0,0 +1,9 @@
226+add_subdirectory(tests)
227+#add_subdirectory(files)
228+
229+# make the emulator files visible on qtcreator
230+file(GLOB PYTHON_EMULATOR_FILES
231+ RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}
232+ *.py)
233+
234+add_custom_target(com_ubuntu_docviewer_PYTHONEMULATORFiles ALL SOURCES ${PYTHON_EMULATOR_FILES})
235
236=== added file 'tests/autopilot/ubuntu_docviewer_app/tests/CMakeLists.txt'
237--- tests/autopilot/ubuntu_docviewer_app/tests/CMakeLists.txt 1970-01-01 00:00:00 +0000
238+++ tests/autopilot/ubuntu_docviewer_app/tests/CMakeLists.txt 2014-09-18 18:07:33 +0000
239@@ -0,0 +1,6 @@
240+# make the test files visible on qtcreator
241+file(GLOB PYTHON_TEST_FILES
242+ RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}
243+ *.py)
244+
245+add_custom_target(com_ubuntu_docviewer_PYTHONTESTFiles ALL SOURCES ${PYTHON_TEST_FILES})
246
247=== modified file 'tests/autopilot/ubuntu_docviewer_app/tests/__init__.py'
248--- tests/autopilot/ubuntu_docviewer_app/tests/__init__.py 2014-09-11 11:49:23 +0000
249+++ tests/autopilot/ubuntu_docviewer_app/tests/__init__.py 2014-09-18 18:07:33 +0000
250@@ -27,7 +27,7 @@
251 scenarios = [('with touch', dict(input_device_class=Touch))]
252
253 local_location = "../../ubuntu-docviewer-app.qml"
254- sample_dir = "/usr/lib/python2.7/dist-packages/"
255+ sample_dir = "/usr/lib/python3/dist-packages/"
256
257 def setUp(self):
258 self.pointing_device = Pointer(self.input_device_class.create())
259
260=== removed file 'ubuntu-docviewer-app.desktop'
261--- ubuntu-docviewer-app.desktop 2014-09-13 16:12:14 +0000
262+++ ubuntu-docviewer-app.desktop 1970-01-01 00:00:00 +0000
263@@ -1,12 +0,0 @@
264-[Desktop Entry]
265-Encoding=UTF-8
266-Version=1.0
267-Type=Application
268-Terminal=false
269-Exec=qmlscene %f ubuntu-docviewer-app.qml
270-Icon=docviewer@30.png
271-Name=Document Viewer
272-MimeType=text/plain;image/png;image/jpeg;image/svg+xml;application/pdf
273-Path=/usr/share/ubuntu-docviewer-app
274-X-Ubuntu-Touch=true
275-X-Ubuntu-StageHint=SideStage
276
277=== added file 'ubuntu-docviewer-app.desktop.in.in'
278--- ubuntu-docviewer-app.desktop.in.in 1970-01-01 00:00:00 +0000
279+++ ubuntu-docviewer-app.desktop.in.in 2014-09-18 18:07:33 +0000
280@@ -0,0 +1,12 @@
281+[Desktop Entry]
282+Encoding=UTF-8
283+Version=1.0
284+Type=Application
285+Terminal=false
286+Exec=@EXEC@
287+Icon=@ICON@
288+Name=Document Viewer
289+MimeType=text/plain;image/png;image/jpeg;image/svg+xml;application/pdf
290+Path=/usr/share/ubuntu-docviewer-app
291+X-Ubuntu-Touch=true
292+X-Ubuntu-StageHint=SideStage
293
294=== removed file 'ubuntu-docviewer-app.qmlproject'
295--- ubuntu-docviewer-app.qmlproject 2014-09-11 11:49:23 +0000
296+++ ubuntu-docviewer-app.qmlproject 1970-01-01 00:00:00 +0000
297@@ -1,35 +0,0 @@
298-/* File generated by Qt Creator, version 2.6.1 */
299-
300-import QmlProject 1.1
301-
302-Project {
303- mainFile: "ubuntu-docviewer-app.qml"
304-
305- /* Include .qml, .js, and image files from current directory and subdirectories */
306- QmlFiles {
307- directory: "."
308- }
309- JavaScriptFiles {
310- directory: "."
311- }
312- ImageFiles {
313- directory: "."
314- }
315- /* Shows the README files in the project view */
316- Files {
317- filter: "README*"
318- }
319- /* Shows the autopilot files in the project view */
320- Files {
321- filter: "*.py"
322- }
323- /* Shows the translation files and the .pro file used to generate the .pot template */
324- Files {
325- filter: "*.po*"
326- }
327- Files {
328- filter: "*.pro"
329- }
330- /* List of plugin directories passed to QML runtime */
331- importPaths: [ "." ,"/usr/lib/x86_64-linux-gnu/qt5/qml" ]
332-}

Subscribers

People subscribed via source and target branches