Code review comment for lp:~fboucault/unity-2d/spread_limit_sizes

Revision history for this message
Florian Boucault (fboucault) wrote :

I did extensive framerate analysis with the raster drawing backend on my laptop and for that particular patch I obtained a relevant gain in frame rendering time of a few milliseconds, up to around 5ms.

The following measurements were done with QML_SHOW_FRAMERATE=1 on the last frames when exiting the spread after having pressed escape.

limited to 512px

unity-2d-spread: [DEBUG] paintEvent: 14 time since last frame: 21
unity-2d-spread: [DEBUG] paintEvent: 18 time since last frame: 24
unity-2d-spread: [DEBUG] paintEvent: 18 time since last frame: 27
unity-2d-spread: [DEBUG] paintEvent: 25 time since last frame: 28
unity-2d-spread: [DEBUG] paintEvent: 26 time since last frame: 36
unity-2d-spread: [DEBUG] paintEvent: 30 time since last frame: 38

no limit

unity-2d-spread: [DEBUG] paintEvent: 16 time since last frame: 18
unity-2d-spread: [DEBUG] paintEvent: 18 time since last frame: 23
unity-2d-spread: [DEBUG] paintEvent: 23 time since last frame: 28
unity-2d-spread: [DEBUG] paintEvent: 30 time since last frame: 33
unity-2d-spread: [DEBUG] paintEvent: 34 time since last frame: 41
unity-2d-spread: [DEBUG] paintEvent: 35 time since last frame: 49

« Back to merge proposal