Code review comment for lp:~fahad-aizaz/hipl/hip-cert-conf

Diego Biurrun (diego-biurrun) wrote :

On Sat, Jan 28, 2012 at 07:09:32PM +0100, René Hummen wrote:
> On 25.01.2012, at 16:14, Fahad Aizaz wrote:
> > Fahad Aizaz has proposed merging lp:~fahad-aizaz/hipl/hip-cert-conf into lp:hipl.
> >
> @all: As I mentioned in
> https://code.launchpad.net/~henrik-ziegeldorf/hipl/pisa-merge/+merge/8
> 5871, I suggest to replace the current certificate code with the by
> far more complete certificate functionality provided by the pisa
> branch.
>
> Can we agree on my suggestion?

It's not clear to me how your suggestion applies to this branch.
This merge proposal is small and close to merging, pisa-merge is
huge and still in need of considerable work.

> > --- hipd/init.c 2011-12-13 13:50:53 +0000
> > +++ hipd/init.c 2012-01-25 15:13:34 +0000
> > @@ -465,81 +435,6 @@
> >
> > -/* Needed if the configuration file for certs did not exist */
> > -#define HIP_CERT_INIT_DAYS 10
>
> ... and once we are on it, we can also use this define instead of
> the parameter in the configuration file. This change would make
> hip_cert.conf obsolete.

How can build-time configuration make run-time configuration obsolete?

Diego

« Back to merge proposal