Code review comment for lp:~fagerstedt-axel/lava-android-test/ashmemtest

Revision history for this message
Andy Doan (doanac) wrote :

nice job for a first submission :)

A couple of small doc-related things:

1) in tests.rst I'd just call it "ashmemtest" and "command-ashmemtest".

2) in ashmemetest.py could you add a docstring near the top like line 21 of:
 http://bazaar.launchpad.net/~linaro-validation/lava-android-test/trunk/view/head:/lava_android_test/test_definitions/busybox.py

By getting that done correctly, our tests will have nice documenation available at:
  http://lava-android-test.readthedocs.org/en/latest/tests.html

review: Needs Fixing

« Back to merge proposal