Merge lp:~fagerstedt-axel/lava-android-test/ashmemtest into lp:lava-android-test

Proposed by Axel Fagerstedt
Status: Merged
Merged at revision: 227
Proposed branch: lp:~fagerstedt-axel/lava-android-test/ashmemtest
Merge into: lp:lava-android-test
Diff against target: 59 lines (+37/-0)
2 files modified
doc/tests.rst (+5/-0)
lava_android_test/test_definitions/commands/ashmemtest.py (+32/-0)
To merge this branch: bzr merge lp:~fagerstedt-axel/lava-android-test/ashmemtest
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
Review via email: mp+143658@code.launchpad.net

Description of the change

Add new test ashmemtest

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

nice job for a first submission :)

A couple of small doc-related things:

1) in tests.rst I'd just call it "ashmemtest" and "command-ashmemtest".

2) in ashmemetest.py could you add a docstring near the top like line 21 of:
 http://bazaar.launchpad.net/~linaro-validation/lava-android-test/trunk/view/head:/lava_android_test/test_definitions/busybox.py

By getting that done correctly, our tests will have nice documenation available at:
  http://lava-android-test.readthedocs.org/en/latest/tests.html

review: Needs Fixing
228. By Axel Fagerstedt

Update ashmemtest documentation.

Revision history for this message
Axel Fagerstedt (fagerstedt-axel) wrote :

Hi Andy,

Thanks for the comments, updated.

I was not able to figure out how to update my existing commit in bzr so I pushed a second commit into my existing branch. I hope this is the correct way to do it when working with bzr and lp?

Revision history for this message
Andy Doan (doanac) wrote :

that's the correct way to update it. I'll merge the code now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/tests.rst'
2--- doc/tests.rst 2012-09-26 21:35:40 +0000
3+++ doc/tests.rst 2013-01-18 14:15:23 +0000
4@@ -22,6 +22,7 @@
5 * `v8`_
6 * `wifi`_
7 * `0xbench`_
8+ * `ashmemtest`_
9 * `commands`_
10 * `instruments`_
11 * `hostshells`_
12@@ -87,6 +88,10 @@
13 ++++
14 .. automodule:: lava_android_test.test_definitions.wifi
15
16+ashmemtest
17+++++++++
18+.. automodule:: lava_android_test.test_definitions.commands.ashmemtest
19+
20 commands
21 ++++++++
22 .. automodule:: lava_android_test.test_definitions.commands
23
24=== added file 'lava_android_test/test_definitions/commands/ashmemtest.py'
25--- lava_android_test/test_definitions/commands/ashmemtest.py 1970-01-01 00:00:00 +0000
26+++ lava_android_test/test_definitions/commands/ashmemtest.py 2013-01-18 14:15:23 +0000
27@@ -0,0 +1,32 @@
28+# Copyright (c) 2012 Linaro
29+
30+# Author: Linaro Validation Team <linaro-dev@lists.linaro.org>
31+#
32+# This file is part of LAVA Android Test.
33+#
34+#
35+# This program is free software: you can redistribute it and/or modify
36+# it under the terms of the GNU General Public License as published by
37+# the Free Software Foundation, either version 3 of the License, or
38+# (at your option) any later version.
39+#
40+# This program is distributed in the hope that it will be useful,
41+# but WITHOUT ANY WARRANTY; without even the implied warranty of
42+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
43+# GNU General Public License for more details.
44+#
45+# You should have received a copy of the GNU General Public License
46+# along with this program. If not, see <http://www.gnu.org/licenses/>.
47+"""
48+This is basic unit test for the ashmem driver.
49+
50+**URL:** None
51+
52+**Default Options:** None
53+"""
54+import lava_android_test.testdef
55+
56+test_name = 'ashmem'
57+
58+RUN_ADB_SHELL_STEPS = ['ashmemtest']
59+PATTERN = "\s*\[(?P<test_case_id>\w+)\]:\s\w+\s(?P<result>\w+)"

Subscribers

People subscribed via source and target branches