Code review comment for lp:~factorlibre/openerp-connector-magento/openerp-connector-magento-php54-none-values

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Hi,

Thanks for this patch.
What you want is to remove trailing None values, but you remove all None values.
Example, if you have: [7, None, 4, None], you patch will give [7, 4].

Here is want you want:

    if isinstance(arguments, list):
        while arguments and arguments[-1] is None:
            arguments.pop()

Thanks to run the unittests and fix them accordingly. The test data will certainly need to be adapted.

review: Needs Fixing (code review)

« Back to merge proposal