Merge lp:~factorlibre/openerp-connector-magento/openerp-connector-magento-php54-none-values into lp:~openerp-connector-core-editors/openerp-connector-magento/7.0

[Alberto Garcia (Factor Libre)]

[lp:~factorlibre/openerp-connector-magento/openerp-connector-magento-php54-none-values]

1007. By Alberto Garcia (Factor Libre) on 2014-06-30

Fix api call

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Hi,

Thanks for this patch.
What you want is to remove trailing None values, but you remove all None values.
Example, if you have: [7, None, 4, None], you patch will give [7, 4].

Here is want you want:

    if isinstance(arguments, list):
        while arguments and arguments[-1] is None:
            arguments.pop()

Thanks to run the unittests and fix them accordingly. The test data will certainly need to be adapted.

review: Needs Fixing (code review)

[lp:~factorlibre/openerp-connector-magento/openerp-connector-magento-php54-none-values]

1008. By Alberto Garcia (Factor Libre) on 2014-06-30

Fix

[Alberto Garcia (Factor Libre) (agarcia-flibre)]

How can I run tests? Y have done new commit with your changes

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

On Mon, Jun 30, 2014 at 3:39 PM, Alberto Garcia (Factor Libre)
<email address hidden> wrote:
> How can I run tests? Y have done new commit with your changes

http://openerp-magento-connector.com/project/contribute.html#run-the-tests

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

This project is now hosted on https://github.com/OCA/connector-magento. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Unmerged revisions

1008. By Alberto Garcia (Factor Libre) on 2014-06-30

Fix

1007. By Alberto Garcia (Factor Libre) on 2014-06-30

Fix api call

1006. By Alberto Garcia (Factor Libre) on 2014-06-30

Delete None parameters for connector when Magento use php => 5.4

=== modified file 'magentoerpconnect/unit/backend_adapter.py'
--- magentoerpconnect/unit/backend_adapter.py	2014-05-26 09:37:00 +0000
+++ magentoerpconnect/unit/backend_adapter.py	2014-06-30 13:39:15 +0000
@@ -153,7 +153,16 @@
                                 self.magento.username,
                                 self.magento.password,
                                 full_url=custom_url) as api:
+                                  
+                
+                # If magento is used with PHP version >= 5.4, then we have to remove all
+                # trailing None values
+                if isinstance(arguments, list):
+                    while arguments and arguments[-1] is None:
+                        arguments.pop()
+               
                 result = api.call(method, arguments)
+
                 # Uncomment to record requests/responses in ``recorder``
                 # record(method, arguments, result)
                 _logger.debug("api.call(%s, %s) returned %s",