Merge lp:~f-thiessen/kicad/install-script-update into lp:kicad/product

Proposed by Ferdinand T. on 2015-04-17
Status: Rejected
Rejected by: Chris Pavlina on 2016-01-15
Proposed branch: lp:~f-thiessen/kicad/install-script-update
Merge into: lp:kicad/product
Diff against target: 67 lines (+39/-2)
1 file modified
scripts/kicad-install.sh (+39/-2)
To merge this branch: bzr merge lp:~f-thiessen/kicad/install-script-update
Reviewer Review Type Date Requested Status
kicad-product-committers 2015-04-17 Pending
Review via email: mp+256610@code.launchpad.net

Description of the change

Added support for openSUSE (pm is zypper) for the kicad installation script.

To post a comment you must log in.
Miguel Angel Ajo (mangelajo) wrote :
Download full text (3.2 KiB)

Hi Ferdinand,

  I believe the plan forward is to remove the kicad-install.sh from the repository,
since we are getting into a better position to offer built binaries for every platform
(nightly and stable).

Best,
Miguel Ángel.

> On 17/4/2015, at 2:23, Ferdinand T. <email address hidden> wrote:
>
> Ferdinand T. has proposed merging lp:~f-thiessen/kicad/install-script-update into lp:kicad.
>
> Requested reviews:
> kicad-product-committers (kicad-product-committers)
>
> For more details, see:
> https://code.launchpad.net/~f-thiessen/kicad/install-script-update/+merge/256610
>
> Added support for openSUSE (pm is zypper) for the kicad installation script.
> --
> You are subscribed to branch lp:kicad.
> === modified file 'scripts/kicad-install.sh'
> --- scripts/kicad-install.sh 2015-03-30 21:29:04 +0000
> +++ scripts/kicad-install.sh 2015-04-17 00:22:33 +0000
> @@ -2,6 +2,7 @@
> # Install KiCad from source onto either:
> # -> a Ubuntu/Debian/Mint or
> # -> a Red Hat
> +# -> a openSUSE
> # compatible linux system.
> #
> # The "install_prerequisites" step is the only "distro dependent" one. That step could be modified
> @@ -95,7 +96,7 @@
> install_prerequisites()
> {
> # Find a package manager, PM
> - PM=$( command -v yum || command -v apt-get )
> + PM=$( command -v yum || command -v apt-get || command -v zypper )
>
> # assume all these Debian, Mint, Ubuntu systems have same prerequisites
> if [ "$(expr match "$PM" '.*\(apt-get\)')" == "apt-get" ]; then
> @@ -184,9 +185,45 @@
> sudo yum install $sp || exit 1
> done
> fi
> + # assume all zypper systems like openSUSE have same prerequisites
> + elif [ "$(expr match "$PM" '.*\(zypper\)')" == "zypper" ]; then
> + #echo "slackware / openSUSE compatible system"
> + # openSUSE does not have bzrtools in standard repositories, so look at http://software.opensuse.org/package/bzrtools?search_term=bzrtools
> + # Note: if you find this list not to be accurate, please submit a patch:
> + prerequisite_list="
> + bzr
> + libzip2
> + libbz2-devel
> + cmake
> + cmake-gui
> + doxygen
> + cairo-devel
> + glew-devel
> + grep
> + libopenssl-devel
> + wxWidgets-3_0-devel
> + "
> +
> + for p in ${prerequisite_list}
> + do
> + sudo zypper in $p || exit 1
> + done
> +
> + # Only install the scripting prerequisites if required.
> + if [ "$(expr match "$OPTS" '.*\(-DKICAD_SCRIPTING=ON\)')" == "-DKICAD_SCRIPTING=ON" ]; then
> + #echo "KICAD_SCRIPTING=ON"
> + scripting_prerequisites="
> + python-wxWidgets
> + "
> +
> + for sp in ${scripting_prerequisites}
> + do
> + sudo zypper in $sp || exit 1
> + done
> + fi
> else
> echo
> - echo "Incompatible System. Neither 'yum' nor 'apt-get' found. Not possible to continue."
> + echo "Incompatible System. Neither 'yum' nor 'apt-get' nor 'zypper' found. Not possible to continue."
> ech...

Read more...

Chris Pavlina (pavlina-chris) wrote :

Indeed, kicad-install.sh is deprecated and will be removed.

Unmerged revisions

5605. By Ferdinand T. on 2015-04-17

Slightly modified install script (see also last commit).

5604. By Ferdinand T. on 2015-04-16

Added zypper support (e.g. openSUSE) for kicad install script.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'scripts/kicad-install.sh'
--- scripts/kicad-install.sh 2015-03-30 21:29:04 +0000
+++ scripts/kicad-install.sh 2015-04-17 00:22:33 +0000
@@ -2,6 +2,7 @@
2# Install KiCad from source onto either:2# Install KiCad from source onto either:
3# -> a Ubuntu/Debian/Mint or3# -> a Ubuntu/Debian/Mint or
4# -> a Red Hat4# -> a Red Hat
5# -> a openSUSE
5# compatible linux system.6# compatible linux system.
6#7#
7# The "install_prerequisites" step is the only "distro dependent" one. That step could be modified8# The "install_prerequisites" step is the only "distro dependent" one. That step could be modified
@@ -95,7 +96,7 @@
95install_prerequisites()96install_prerequisites()
96{97{
97 # Find a package manager, PM98 # Find a package manager, PM
98 PM=$( command -v yum || command -v apt-get )99 PM=$( command -v yum || command -v apt-get || command -v zypper )
99100
100 # assume all these Debian, Mint, Ubuntu systems have same prerequisites101 # assume all these Debian, Mint, Ubuntu systems have same prerequisites
101 if [ "$(expr match "$PM" '.*\(apt-get\)')" == "apt-get" ]; then102 if [ "$(expr match "$PM" '.*\(apt-get\)')" == "apt-get" ]; then
@@ -184,9 +185,45 @@
184 sudo yum install $sp || exit 1185 sudo yum install $sp || exit 1
185 done186 done
186 fi187 fi
188 # assume all zypper systems like openSUSE have same prerequisites
189 elif [ "$(expr match "$PM" '.*\(zypper\)')" == "zypper" ]; then
190 #echo "slackware / openSUSE compatible system"
191 # openSUSE does not have bzrtools in standard repositories, so look at http://software.opensuse.org/package/bzrtools?search_term=bzrtools
192 # Note: if you find this list not to be accurate, please submit a patch:
193 prerequisite_list="
194 bzr
195 libzip2
196 libbz2-devel
197 cmake
198 cmake-gui
199 doxygen
200 cairo-devel
201 glew-devel
202 grep
203 libopenssl-devel
204 wxWidgets-3_0-devel
205 "
206
207 for p in ${prerequisite_list}
208 do
209 sudo zypper in $p || exit 1
210 done
211
212 # Only install the scripting prerequisites if required.
213 if [ "$(expr match "$OPTS" '.*\(-DKICAD_SCRIPTING=ON\)')" == "-DKICAD_SCRIPTING=ON" ]; then
214 #echo "KICAD_SCRIPTING=ON"
215 scripting_prerequisites="
216 python-wxWidgets
217 "
218
219 for sp in ${scripting_prerequisites}
220 do
221 sudo zypper in $sp || exit 1
222 done
223 fi
187 else224 else
188 echo225 echo
189 echo "Incompatible System. Neither 'yum' nor 'apt-get' found. Not possible to continue."226 echo "Incompatible System. Neither 'yum' nor 'apt-get' nor 'zypper' found. Not possible to continue."
190 echo227 echo
191 exit 1228 exit 1
192 fi229 fi