Merge lp:~f-thiessen/kicad/install-script-update into lp:kicad/product
Proposed by
Ferdinand T.
Status: | Rejected |
---|---|
Rejected by: | Chris Pavlina |
Proposed branch: | lp:~f-thiessen/kicad/install-script-update |
Merge into: | lp:kicad/product |
Diff against target: |
67 lines (+39/-2) 1 file modified
scripts/kicad-install.sh (+39/-2) |
To merge this branch: | bzr merge lp:~f-thiessen/kicad/install-script-update |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
KiCad Lead Developers | Pending | ||
Review via email: mp+256610@code.launchpad.net |
Description of the change
Added support for openSUSE (pm is zypper) for the kicad installation script.
To post a comment you must log in.
Unmerged revisions
- 5605. By Ferdinand T.
-
Slightly modified install script (see also last commit).
- 5604. By Ferdinand T.
-
Added zypper support (e.g. openSUSE) for kicad install script.
Hi Ferdinand,
I believe the plan forward is to remove the kicad-install.sh from the repository,
since we are getting into a better position to offer built binaries for every platform
(nightly and stable).
Best,
Miguel Ángel.
> On 17/4/2015, at 2:23, Ferdinand T. <email address hidden> wrote: committers (kicad- product- committers) /code.launchpad .net/~f- thiessen/ kicad/install- script- update/ +merge/ 256610 kicad-install. sh' kicad-install. sh 2015-03-30 21:29:04 +0000 kicad-install. sh 2015-04-17 00:22:33 +0000 prerequisites" step is the only "distro dependent" one. That step could be modified prerequisites( ) software. opensuse. org/package/ bzrtools? search_ term=bzrtools list} SCRIPTING= ON\)')" == "-DKICAD_ SCRIPTING= ON" ]; then SCRIPTING= ON" prerequisites= " prerequisites}
>
> Ferdinand T. has proposed merging lp:~f-thiessen/kicad/install-script-update into lp:kicad.
>
> Requested reviews:
> kicad-product-
>
> For more details, see:
> https:/
>
> Added support for openSUSE (pm is zypper) for the kicad installation script.
> --
> You are subscribed to branch lp:kicad.
> === modified file 'scripts/
> --- scripts/
> +++ scripts/
> @@ -2,6 +2,7 @@
> # Install KiCad from source onto either:
> # -> a Ubuntu/Debian/Mint or
> # -> a Red Hat
> +# -> a openSUSE
> # compatible linux system.
> #
> # The "install_
> @@ -95,7 +96,7 @@
> install_
> {
> # Find a package manager, PM
> - PM=$( command -v yum || command -v apt-get )
> + PM=$( command -v yum || command -v apt-get || command -v zypper )
>
> # assume all these Debian, Mint, Ubuntu systems have same prerequisites
> if [ "$(expr match "$PM" '.*\(apt-get\)')" == "apt-get" ]; then
> @@ -184,9 +185,45 @@
> sudo yum install $sp || exit 1
> done
> fi
> + # assume all zypper systems like openSUSE have same prerequisites
> + elif [ "$(expr match "$PM" '.*\(zypper\)')" == "zypper" ]; then
> + #echo "slackware / openSUSE compatible system"
> + # openSUSE does not have bzrtools in standard repositories, so look at http://
> + # Note: if you find this list not to be accurate, please submit a patch:
> + prerequisite_list="
> + bzr
> + libzip2
> + libbz2-devel
> + cmake
> + cmake-gui
> + doxygen
> + cairo-devel
> + glew-devel
> + grep
> + libopenssl-devel
> + wxWidgets-3_0-devel
> + "
> +
> + for p in ${prerequisite_
> + do
> + sudo zypper in $p || exit 1
> + done
> +
> + # Only install the scripting prerequisites if required.
> + if [ "$(expr match "$OPTS" '.*\(-DKICAD_
> + #echo "KICAD_
> + scripting_
> + python-wxWidgets
> + "
> +
> + for sp in ${scripting_
> + do
> + sudo zypper in $sp || exit 1
> + done
> + fi
> else
> echo
> - echo "Incompatible System. Neither 'yum' nor 'apt-get' found. Not possible to continue."
> + echo "Incompatible System. Neither 'yum' nor 'apt-get' nor 'zypper' found. Not possible to continue."
> ech...