Code review comment for lp:~exsdev/landscape-client-charm/juju-app-annotator

Revision history for this message
Stephan Pampel (stephanpampel) wrote :

@exsdev I looked into improving the things that Simon mentioned. One thing I am wondering is why the cronjob is necessary?
I checked locally and on some deployments and the update-status hook is called on each client every ~5 min. Is that not frequent enough to set the annotations?

The update-status hook is currently not implemented but could be added. Avoiding the cronjob might make the code simpler and less error prone.

« Back to merge proposal