lp:~exsdev/landscape-client-charm/juju-app-annotator

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:landscape-client-charm

🤖 Landscape Builder: Needs Fixing (test results) on 2021-11-11

Landscape: Pending requested 2021-09-17

Diff: 339 lines (+268/-1)

6 files modified

files/landscape-annotator.cron (+1/-0)
files/landscape-annotator.sudoers (+1/-0)
files/landscape_annotator.py (+105/-0)
hooks/hooks.py (+2/-1)
hooks/install.py (+28/-0)
tests/20-landscape-annotator.py (+131/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

75. By Edin S on 2021-09-22

Add hooks for deploying Landscape annotator scripts (and supporting files)

74. By Edin S on 2021-09-22

Add Landscape annotator tests

73. By Edin S on 2021-09-22

Add script and supporting files for registering juju apps as Landscape annotations

A few notes about the design choices:
1. The script is run via a cronjob
The alternative (which was attempted previously) was to run register
annotation code whenever charms were deployed/removed. The issue with
this design is that removing other subordinate charms (e.g. filebeat)
did not trigger any code in this charm (e.g. config-changed, or
update-status) to ensure frequent updates of annotations.

2. Annotation deployment status (e.g. deployed/removed) are tracked
via annotation values: deployed={true,false}.
This is required to keep track of which applications have been
removed. While annotations are registered by creating a file in
annotations.d, removing the same file does not remove the
annotation. As such annotations are always kept around, but their
values/contents are changed (e.g. deployed=true ->
deployed=false). The accompanying landscape-tagger code then
adds/removes the annotations as tags on landscape-server.

72. By Simon Poirier on 2021-03-17

Add showing charm source version/commit in juju status output

71. By Simon Poirier on 2020-02-22

Support for focal

70. By Simon Poirier on 2020-01-28

Update icon per lp#1686721

69. By Simon Poirier on 2019-07-02

Merge sync-charmhelpers-and-keys [f=1834223] [r=roadmr,landscape-builder] [a=Simon Poirier]
Sync charmhelpers to avoid key errors on refresh.

68. By Adam Collard on 2019-04-05

Add install_sources and install_keys support to landscape-client charm

67. By Simon Poirier on 2018-11-08

Handle py2 and py3 by opening a file in wb mode.

66. By Simon Poirier on 2018-02-27

Merge 1750668_bionic_py3_support [f=1750668] [r=chad.smith,landscape-builder] [a=Simon Poirier]
Wrap hooks hooks to run on version used by landscape-client and correct a couple imports which changed.