Code review comment for lp:~evarlast/charms/trusty/logstash-forwarder/add-logs-relation

Revision history for this message
Jay R. Wren (evarlast) wrote :

I addressed most the code issues.

Regarding the relation data: IMO to keep things simple on the other side of the relation, this makes the most sense. It turns out that logstash-forwarder is quite OK with single files configured with the same type. The simplicity of file, type pair is intentional. No need for added complexity. The restriction on an extra field is also by design. Parallel arrays were used for files and lists, an additional parallel array could be given by any charm implementing the logs interface, and this charm consuming the interface would ignore it. This is flexible and simple.

Can it land now?

« Back to merge proposal