Merge lp:~evarlast/charms/trusty/logstash-forwarder/add-logs-relation into lp:~canonical-is-sa/charms/trusty/logstash-forwarder/trunk
Proposed by
Jay R. Wren
Status: | Merged |
---|---|
Merged at revision: | 16 |
Proposed branch: | lp:~evarlast/charms/trusty/logstash-forwarder/add-logs-relation |
Merge into: | lp:~canonical-is-sa/charms/trusty/logstash-forwarder/trunk |
Diff against target: |
222 lines (+142/-3) 4 files modified
config.yaml (+3/-0) hooks/hooks.py (+41/-2) hooks/test_hooks.py (+94/-0) metadata.yaml (+4/-1) |
To merge this branch: | bzr merge lp:~evarlast/charms/trusty/logstash-forwarder/add-logs-relation |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Greg Mason (community) | Approve | ||
Michael Nelson (community) | Approve | ||
Review via email: mp+277493@code.launchpad.net |
Description of the change
add logs relation
To post a comment you must log in.
Thanks Jay. This generally looks good. I'm not sure, but did you forget to commit the hooks/logs- relation- * symlinks, or are they no longer required?
I've a few other comments below. My main concern is the format that you're using for the relation data - in that I think it will restrict our future options (ie. if in the future we want to have two files for one type, or have extra fields for a file type). See below for more.
Let me know what you think.