Juju Charms Collection
logstash-forwarder package

Code review comment for lp:~evarlast/charms/trusty/logstash-forwarder/add-logs-relation

  1. Trusty Tahr (14.04)
  2. add-logs-relation
  3. Merge into trunk
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Thanks Jay. This generally looks good. I'm not sure, but did you forget to commit the hooks/logs-relation-* symlinks, or are they no longer required?

I've a few other comments below. My main concern is the format that you're using for the relation data - in that I think it will restrict our future options (ie. if in the future we want to have two files for one type, or have extra fields for a file type). See below for more.

Let me know what you think.

« Back to merge proposal