Code review comment for lp:~ev/ubiquity/translated_layouts

Revision history for this message
Evan (ev) wrote :

I know you guys are busy, but I wanted to give everyone an opportunity to review this before I landed it on trunk. This and the accompanying console-setup branch add translated keyboard names to ubiquity, per the foundations-lucid-oem-config-localized-keyboard-layout specification.

I'm not entirely sold on shoving 1.5M of text into Python data structures. If it's an issue for the rest of you, I'll do away with keyboard_names.py and modify ubiquity to directly scan the kbdnames.gz file.

Please also see lp:~ev/console-setup/translated_layouts (merged from Debian), which is a prerequisite for this branch.

Thanks

« Back to merge proposal