Ubuntu
systemd package

Code review comment for ~enr0n/ubuntu/+source/systemd:ubuntu-jammy

  1. Git
  2. lp:~enr0n/ubuntu/+source/systemd
  3. ubuntu-jammy
  4. Merge into ubuntu-jammy
Revision history for this message
Lukas Märdian (slyon) wrote :

Thanks for executing autopkgtests and test builds in a PPA!

I verified that the patch cherry-picked from upstream matches upstream's logic (lp2037281-core-device-ignore-DEVICE_FOUND_UDEV-bit-on-switching-roo.patch), so that should be fine.

Also the logic in the Ubuntu Core read-only-etc hacks patch is looking good to me. It's sad that we cannot find a better way around this, other than patching systemd. But from reading the bug report comments that seems to be hard. I have one remark about this specific patch:

- bug #2035122 needs to be integrated in Noble's UBUNTU-read-only-etc-hacks.patch.
=> Will this happen with the next systemd merge? Please state your plans in the bug report, so it's clear to the SRU team, also target it to the other missing series (Lunar, Mantic), marking it WONTFIX, as this only applies to Ubuntu Core.

Otherwise, those changes seem to be fine!

review: Approve

« Back to merge proposal