Merge ~emitorino/review-tools:add_rocks_team_to_overrides into review-tools:master

Proposed by Emilia Torino
Status: Merged
Merged at revision: 7631ed0d199506d9c86303feb6b2c56dd0ff748e
Proposed branch: ~emitorino/review-tools:add_rocks_team_to_overrides
Merge into: review-tools:master
Diff against target: 18 lines (+5/-2)
1 file modified
reviewtools/overrides.py (+5/-2)
Reviewer Review Type Date Requested Status
Alex Murray Approve
Review via email: mp+416263@code.launchpad.net

Commit message

- overrides.py: add rocks team members to canonical_rocks email overrides

Description of the change

When the ROCKs USN notification service was created, the server team did not confirm who should added to this overrides so we kept it empty. The "rocks store db" was created having <email address hidden> as the publisher to all rocks revisions so he would be the person getting the notifications meanwhile.

The server team has been asking to add Athos as well since last year so that's why I am creating this MP. Ideally all emails should be sent to the <email address hidden> email list but since that is not yet working, let's fix this override and add Sergio and Athos anyways.

To post a comment you must log in.
Revision history for this message
Alex Murray (alexmurray) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/reviewtools/overrides.py b/reviewtools/overrides.py
index e439806..35b5c0c 100644
--- a/reviewtools/overrides.py
+++ b/reviewtools/overrides.py
@@ -1006,8 +1006,11 @@ canonical_multipass = canonical_mir
10061006
1007canonical_openstack = ["billy.olsen@canonical.com", "james.page@canonical.com"]1007canonical_openstack = ["billy.olsen@canonical.com", "james.page@canonical.com"]
10081008
1009# TODO: Add Canonical rocks team1009canonical_rocks = [
1010canonical_rocks = []1010 "athos.ribeiro@canonical.com",
1011 "sergio.durigan@canonical.com",
1012 "ubuntu-docker-images@lists.launchpad.net",
1013]
10111014
1012canonical_security = [1015canonical_security = [
1013 "alex.murray@canonical.com",1016 "alex.murray@canonical.com",

Subscribers

People subscribed via source and target branches