Code review comment for lp:~elopio/u1-test-utils/smart_scopes_tests

Revision history for this message
Vincent Ladeuil (vila) wrote :

26 +def _wait_for_result_settle(test):

Why don't you use Eventually here ?

It seems unlikely that the code will loop forever but it can be exited with 0 rows. Why not use a specific number of rows and an overall timeout (which Eventually implements) instead ?

review: Needs Information

« Back to merge proposal