Merge lp:~elopio/u1-test-utils/smart_scopes_tests into lp:~canonical-isd-hackers/u1-test-utils/test-in-dash-payments
Proposed by
Leo Arias
Status: | Rejected |
---|---|
Rejected by: | Natalia Bidart |
Proposed branch: | lp:~elopio/u1-test-utils/smart_scopes_tests |
Merge into: | lp:~canonical-isd-hackers/u1-test-utils/test-in-dash-payments |
Diff against target: |
143 lines (+91/-2) 3 files modified
tests/dash.py (+50/-2) tests/schema.py (+4/-0) tests/test_smart_scopes.py (+37/-0) |
To merge this branch: | bzr merge lp:~elopio/u1-test-utils/smart_scopes_tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vincent Ladeuil (community) | Needs Information | ||
Review via email: mp+170969@code.launchpad.net |
To post a comment you must log in.
26 +def _wait_for_ result_ settle( test):
Why don't you use Eventually here ?
It seems unlikely that the code will loop forever but it can be exited with 0 rows. Why not use a specific number of rows and an overall timeout (which Eventually implements) instead ?