Code review comment for lp:~elopio/snapcraft/fix-pep8-and-doc-indentation

Revision history for this message
Snappy Tarmac (snappydevtarmac) wrote :

The attempt to merge lp:~elopio/snapcraft/fix-pep8-and-doc-indentation into lp:snapcraft failed. Below is the output from the failed tests.

name: # the name of the snap
version: # the version of the snap
# The vendor for the snap (replace 'Vendor <email address hidden>')
vendor: Vendor <email address hidden>
summary: # 79 char long summary
description: # A longer description for the snap
icon: # A path to an icon for the package
cp --preserve=all -R zzz /tmp/tmpu9u848ie/parts/copy/install/zzz
cp --preserve=all -R src /tmp/tmp79huuwcn/parts/copy/install/dst
cp --preserve=all -R src /tmp/tmps1vpx7b4/parts/copy/install/dir/dst

...................................Warning: unable to find "test_relexepath" in the path
.................................F.................................
======================================================================
FAIL: test_init_with_source_branch_and_tag_raises_exception (snapcraft.tests.test_sources.TestMercurial)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/tarmac/branch.DenRbR/snapcraft/tests/test_sources.py", line 275, in test_init_with_source_branch_and_tag_raises_exception
    self.assertEqual(raised.exception.message, expected_message)
AssertionError: "can't specify both source-tag and source-branch for a mercurial source" != "can't specify both source-tag and source-branch "
- can't specify both source-tag and source-branch for a mercurial source
? ----------------------
+ can't specify both source-tag and source-branch

======================================================================
FAIL: test_invalid_names (snapcraft.tests.test_yaml.TestValidation) (key='package@awesome')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/tarmac/branch.DenRbR/snapcraft/tests/test_yaml.py", line 373, in test_invalid_names
    msg=data)
AssertionError: "'package@awesome' does not match '^[a-z0-9][a-z0-9+-]*$'" != "'{}' does not match "
- 'package@awesome' does not match '^[a-z0-9][a-z0-9+-]*$'
+ '{}' does not match
 : {'description': 'description which can be pretty long', 'version': '1.0-snapcraft1~ppa1', 'icon': 'my-icon.png', 'vendor': 'Me <email address hidden>', 'summary': 'my summary less that 79 chars', 'name': 'package@awesome', 'parts': {'part1': {'plugin': 'project'}}}

======================================================================
FAIL: test_invalid_names (snapcraft.tests.test_yaml.TestValidation) (key='something.another')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/tarmac/branch.DenRbR/snapcraft/tests/test_yaml.py", line 373, in test_invalid_names
    msg=data)
AssertionError: "'something.another' does not match '^[a-z0-9][a-z0-9+-]*$'" != "'{}' does not match "
- 'something.another' does not match '^[a-z0-9][a-z0-9+-]*$'
+ '{}' does not match
 : {'description': 'description which can be pretty long', 'version': '1.0-snapcraft1~ppa1', 'icon': 'my-icon.png', 'vendor': 'Me <email address hidden>', 'summary': 'my summary less that 79 chars', 'name': 'something.another', 'parts': {'part1': {'plugin': 'project'}}}

======================================================================
FAIL: test_invalid_names (snapcraft.tests.test_yaml.TestValidation) (key='_hideme')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/tarmac/branch.DenRbR/snapcraft/tests/test_yaml.py", line 373, in test_invalid_names
    msg=data)
AssertionError: "'_hideme' does not match '^[a-z0-9][a-z0-9+-]*$'" != "'{}' does not match "
- '_hideme' does not match '^[a-z0-9][a-z0-9+-]*$'
+ '{}' does not match
 : {'description': 'description which can be pretty long', 'version': '1.0-snapcraft1~ppa1', 'icon': 'my-icon.png', 'vendor': 'Me <email address hidden>', 'summary': 'my summary less that 79 chars', 'name': '_hideme', 'parts': {'part1': {'plugin': 'project'}}}

----------------------------------------------------------------------
Ran 103 tests in 2.950s

FAILED (failures=4)

« Back to merge proposal