Code review comment for lp:~elmo/apparmor-profiles/wpa-supplicant

Revision history for this message
Simon Déziel (sdeziel) wrote :

Hi James,

I know you are targeting 15.04, but I (minimally) tested your profile on Trusty and it works well with only this small diff:

$ diff -Naur /tmp/sbin.wpa_supplicant /etc/apparmor.d/sbin.wpa_supplicant
--- /tmp/sbin.wpa_supplicant 2015-04-24 15:39:06.105592941 -0400
+++ /etc/apparmor.d/sbin.wpa_supplicant 2015-04-24 15:57:48.692200225 -0400
@@ -21,10 +21,18 @@
   /run/dbus/system_bus_socket rw,
   /run/sendsigs.omit.d/wpasupplicant.pid rw,

- @{PROC}/@{pid}/psched r,
+ owner @{PROC}/@{pid}/net/psched r,

   /dev/rfkill r,

+ dbus send
+ bus=system
+ path=/org/freedesktop/DBus,
+
+ dbus bind
+ bus=system
+ name={fi.w1.wpa_supplicant1,fi.epitest.hostap.WPASupplicant},
+
   dbus (send, receive)
        bus=system
        path=/fi/w1/wpa_supplicant1,

I don't know if this would be compatible on 15.04 or not.

« Back to merge proposal