Code review comment for lp:~elementary-pantheon/switchboard-plug-security-privacy/abstract-service-panel

Revision history for this message
David Hewitt (davidmhewitt) wrote :

This is good. Definitely simplifies the code in the panels. I think we should maybe look at making the AlertView when a service is disabled and the enabled/disabled status indicators a bit more generic too, so there's not as much repeated code there.

But this is a really good start.

review: Approve (code, function)

« Back to merge proposal