Merge lp:~elementary-pantheon/switchboard-plug-security-privacy/abstract-service-panel into lp:~elementary-apps/switchboard-plug-security-privacy/trunk
Proposed by
Danielle Foré
Status: | Merged |
---|---|
Approved by: | David Hewitt |
Approved revision: | 317 |
Merged at revision: | 317 |
Proposed branch: | lp:~elementary-pantheon/switchboard-plug-security-privacy/abstract-service-panel |
Merge into: | lp:~elementary-apps/switchboard-plug-security-privacy/trunk |
Diff against target: |
415 lines (+126/-102) 8 files modified
src/CMakeLists.txt (+1/-0) src/Plug.vala (+0/-1) src/Views/AbstractServicePanel.vala (+81/-0) src/Views/FirewallPanel.vala (+5/-21) src/Views/LocationPanel.vala (+9/-22) src/Views/LockPanel.vala (+11/-14) src/Views/TrackPanel.vala (+16/-41) src/Widgets/ServiceList.vala (+3/-3) |
To merge this branch: | bzr merge lp:~elementary-pantheon/switchboard-plug-security-privacy/abstract-service-panel |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Hewitt | code, function | Approve | |
Review via email: mp+318808@code.launchpad.net |
Commit message
Create AbstractService
Description of the change
This branch creates an abstract service panel and uses it. The main purpose here is to make sure that we keep the layout and design of each panel consistent and to make it easier to build future panels.
The abstract service panel comes with three areas: header_area, content_area, and action_area. The first one is private and you only interact with it by setting the icon_name, title, description?, and activatable properties of the panel. The latter are public and the naming should be familiar and predictable if you've used Gtk.Dialog
To post a comment you must log in.
This is good. Definitely simplifies the code in the panels. I think we should maybe look at making the AlertView when a service is disabled and the enabled/disabled status indicators a bit more generic too, so there's not as much repeated code there.
But this is a really good start.