Code review comment for lp:~elementary-apps/midori/remove-lightwindow

Revision history for this message
Robert Roth (evfool) wrote :

When clicking Cancel on the dialog (cancel didn't exist on the lightwindow, just closing it didn't crash midori) midori crashes. Here's the stacktrace:
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7b34795 in midori_browser_get_settings (browser=0xfffffffa)
    at /home/evfool/Projects/elementary/remove-lightwindow/midori/midori-browser.c:3008
3008 g_return_val_if_fail (MIDORI_IS_BROWSER (browser), NULL);
(gdb) backtrace
#0 0x00007ffff7b34795 in midori_browser_get_settings (browser=0xfffffffa)
    at /home/evfool/Projects/elementary/remove-lightwindow/midori/midori-browser.c:3008
#1 0x00007ffff7b48105 in midori_private_data_dialog_response_cb (
    button=0xde63a0, browser=0xfffffffa)
    at /home/evfool/Projects/elementary/remove-lightwindow/midori/midori-privatedata.c:52
#2 0x00007ffff78833b8 in g_closure_invoke (closure=0xde3180,
    return_value=0x0, n_param_values=2, param_values=0x7fffffffc9d0,
    invocation_hint=0x7fffffffc970)
    at /build/buildd/glib2.0-2.40.0/./gobject/gclosure.c:768
#3 0x00007ffff7894d3d in signal_emit_unlocked_R (node=node@entry=0x7704b0,
    detail=detail@entry=0, instance=instance@entry=0xde63a0,
    emission_return=emission_return@entry=0x0,
    instance_and_params=instance_and_params@entry=0x7fffffffc9d0)
    at /build/buildd/glib2.0-2.40.0/./gobject/gsignal.c:3551
#4 0x00007ffff789ca29 in g_signal_emit_valist (instance=<optimized out>,
    signal_id=<optimized out>, detail=<optimized out>,
    var_args=var_args@entry=0x7fffffffcb68)
    at /build/buildd/glib2.0-2.40.0/./gobject/gsignal.c:3307
#5 0x00007ffff789cce2 in g_signal_emit (instance=<optimized out>,
    signal_id=<optimized out>, detail=<optimized out>)
    at /build/buildd/glib2.0-2.40.0/./gobject/gsignal.c:3363
---Type <return> to continue, or q <return> to quit---
#6 0x00007ffff78835e7 in _g_closure_invoke_va (closure=0xd16630,
    return_value=0x0, instance=0xd447a0, args=0x7fffffffce18, n_params=0,
    param_types=0x0) at /build/buildd/glib2.0-2.40.0/./gobject/gclosure.c:831
#7 0x00007ffff789c088 in g_signal_emit_valist (instance=0xd447a0,
    signal_id=<optimized out>, detail=0,
    var_args=var_args@entry=0x7fffffffce18)
    at /build/buildd/glib2.0-2.40.0/./gobject/gsignal.c:3215
#8 0x00007ffff789cce2 in g_signal_emit (instance=<optimized out>,
    signal_id=<optimized out>, detail=<optimized out>)
    at /build/buildd/glib2.0-2.40.0/./gobject/gsignal.c:3363
#9 0x00007ffff6cef8fd in gtk_button_do_release (button=0xd447a0,
    emit_clicked=<optimized out>)
    at /build/buildd/gtk+3.0-3.12.2/./gtk/gtkbutton.c:1985
#10 0x00007ffff6cef943 in gtk_real_button_released (button=0xd447a0)
    at /build/buildd/gtk+3.0-3.12.2/./gtk/gtkbutton.c:2103
#11 0x00007ffff78833b8 in g_closure_invoke (closure=0x64ef10,
    return_value=0x0, n_param_values=1, param_values=0x7fffffffd0d0,
    invocation_hint=0x7fffffffd070)
    at /build/buildd/glib2.0-2.40.0/./gobject/gclosure.c:768
#12 0x00007ffff7894557 in signal_emit_unlocked_R (node=node@entry=0x64ef40,
    detail=detail@entry=0, instance=instance@entry=0xd447a0,
    emission_return=emission_return@entry=0x0,
    instance_and_params=instance_and_params@entry=0x7fffffffd0d0)
---Type <return> to continue, or q <return> to quit---
    at /build/buildd/glib2.0-2.40.0/./gobject/gsignal.c:3481
#13 0x00007ffff789ca29 in g_signal_emit_valist (instance=<optimized out>,
    signal_id=<optimized out>, detail=<optimized out>,
    var_args=var_args@entry=0x7fffffffd258)
    at /build/buildd/glib2.0-2.40.0/./gobject/gsignal.c:3307
#14 0x00007ffff789cce2 in g_signal_emit (instance=<optimized out>,
    signal_id=<optimized out>, detail=detail@entry=0)
    at /build/buildd/glib2.0-2.40.0/./gobject/gsignal.c:3363
#15 0x00007ffff6cee861 in gtk_button_button_release (widget=<optimized out>,
    event=<optimized out>)
    at /build/buildd/gtk+3.0-3.12.2/./gtk/gtkbutton.c:1940
#16 0x00007ffff6dc352e in _gtk_marshal_BOOLEAN__BOXEDv (closure=0x640960,
    return_value=0x7fffffffd470, instance=<optimized out>,
    args=<optimized out>, marshal_data=<optimized out>,
    n_params=<optimized out>, param_types=0x640990)
    at /build/buildd/gtk+3.0-3.12.2/./gtk/gtkmarshalers.c:130
#17 0x00007ffff78835e7 in _g_closure_invoke_va (closure=0x640960,
    return_value=0x7fffffffd470, instance=0xd447a0, args=0x7fffffffd578,
    n_params=1, param_types=0x640990)
    at /build/buildd/glib2.0-2.40.0/./gobject/gclosure.c:831
#18 0x00007ffff789c088 in g_signal_emit_valist (instance=0xd447a0,
    signal_id=<optimized out>, detail=0,
    var_args=var_args@entry=0x7fffffffd578)
---Type <return> to continue, or q <return> to quit---
    at /build/buildd/glib2.0-2.40.0/./gobject/gsignal.c:3215
#19 0x00007ffff789cce2 in g_signal_emit (instance=instance@entry=0xd447a0,
    signal_id=<optimized out>, detail=detail@entry=0)
    at /build/buildd/glib2.0-2.40.0/./gobject/gsignal.c:3363
#20 0x00007ffff6ef1c84 in gtk_widget_event_internal (
    widget=widget@entry=0xd447a0, event=event@entry=0xdee3f0)
    at /build/buildd/gtk+3.0-3.12.2/./gtk/gtkwidget.c:7229
#21 0x00007ffff6ef1f69 in gtk_widget_event (widget=widget@entry=0xd447a0,
    event=event@entry=0xdee3f0)
    at /build/buildd/gtk+3.0-3.12.2/./gtk/gtkwidget.c:6891
#22 0x00007ffff6dc0f5c in propagate_event_up (topmost=<optimized out>,
    event=<optimized out>, widget=0xd447a0)
    at /build/buildd/gtk+3.0-3.12.2/./gtk/gtkmain.c:2416
#23 propagate_event (widget=<optimized out>, event=0xdee3f0,
    captured=<optimized out>, topmost=0x0)
    at /build/buildd/gtk+3.0-3.12.2/./gtk/gtkmain.c:2524
#24 0x00007ffff6dc2a25 in gtk_main_do_event (event=0xdee3f0)
    at /build/buildd/gtk+3.0-3.12.2/./gtk/gtkmain.c:1735
#25 0x00007ffff69bbb12 in gdk_event_source_dispatch (source=<optimized out>,
    callback=<optimized out>, user_data=<optimized out>)
    at /build/buildd/gtk+3.0-3.12.2/./gdk/x11/gdkeventsource.c:364
#26 0x00007ffff75b3e04 in g_main_dispatch (context=0x623a00)
    at /build/buildd/glib2.0-2.40.0/./glib/gmain.c:3064
---Type <return> to continue, or q <return> to quit---
#27 g_main_context_dispatch (context=context@entry=0x623a00)
    at /build/buildd/glib2.0-2.40.0/./glib/gmain.c:3663
#28 0x00007ffff75b4048 in g_main_context_iterate (context=0x623a00,
    block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>)
    at /build/buildd/glib2.0-2.40.0/./glib/gmain.c:3734
#29 0x00007ffff75b430a in g_main_loop_run (loop=0x72a3b0)
    at /build/buildd/glib2.0-2.40.0/./glib/gmain.c:3928
#30 0x00007ffff6dc1d15 in gtk_main ()
    at /build/buildd/gtk+3.0-3.12.2/./gtk/gtkmain.c:1192
#31 0x0000000000403a3f in main (argc=1, argv=0x7fffffffddf8)
    at /home/evfool/Projects/elementary/remove-lightwindow/midori/main.c:392

review: Needs Fixing

« Back to merge proposal