Merge lp:~elementary-apps/midori/remove-lightwindow into lp:midori
Proposed by
Danielle Foré
Status: | Merged |
---|---|
Approved by: | Cody Garver |
Approved revision: | 6744 |
Merged at revision: | 6743 |
Proposed branch: | lp:~elementary-apps/midori/remove-lightwindow |
Merge into: | lp:midori |
Diff against target: |
76 lines (+2/-31) 1 file modified
midori/midori-privatedata.c (+2/-31) |
To merge this branch: | bzr merge lp:~elementary-apps/midori/remove-lightwindow |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Roth (community) | Approve | ||
Danielle Foré (community) | Approve | ||
Review via email:
|
Commit message
Drop deprecated Granite LightWindow used for the Clear Private Data dialog
Description of the change
Removes Granite Lightwindow from the clear private data dialog.
To post a comment you must log in.
When clicking Cancel on the dialog (cancel didn't exist on the lightwindow, just closing it didn't crash midori) midori crashes. Here's the stacktrace: browser_ get_settings (browser= 0xfffffffa) Projects/ elementary/ remove- lightwindow/ midori/ midori- browser. c:3008 val_if_ fail (MIDORI_IS_BROWSER (browser), NULL); browser_ get_settings (browser= 0xfffffffa) Projects/ elementary/ remove- lightwindow/ midori/ midori- browser. c:3008 private_ data_dialog_ response_ cb ( 0xde63a0, browser=0xfffffffa) Projects/ elementary/ remove- lightwindow/ midori/ midori- privatedata. c:52 value=0x0, n_param_values=2, param_values= 0x7fffffffc9d0, hint=0x7fffffff c970) buildd/ glib2.0- 2.40.0/ ./gobject/ gclosure. c:768 emit_unlocked_ R (node=node@ entry=0x7704b0, detail@ entry=0, instance= instance@ entry=0xde63a0, return= emission_ return@ entry=0x0, and_params= instance_ and_params@ entry=0x7ffffff fc9d0) buildd/ glib2.0- 2.40.0/ ./gobject/ gsignal. c:3551 emit_valist (instance= <optimized out>, id=<optimized out>, detail=<optimized out>, args=var_ args@entry= 0x7fffffffcb68) buildd/ glib2.0- 2.40.0/ ./gobject/ gsignal. c:3307 <optimized out>, id=<optimized out>, detail=<optimized out>) buildd/ glib2.0- 2.40.0/ ./gobject/ gsignal. c:3363 invoke_ va (closure=0xd16630, value=0x0, instance=0xd447a0, args=0x7fffffff ce18, n_params=0, types=0x0) at /build/ buildd/ glib2.0- 2.40.0/ ./gobject/ gclosure. c:831 emit_valist (instance=0xd447a0, id=<optimized out>, detail=0, args=var_ args@entry= 0x7fffffffce18) buildd/ glib2.0- 2.40.0/ ./gobject/ gsignal. c:3215 <optimized out>, id=<optimized out>, detail=<optimized out>) buildd/ glib2.0- 2.40.0/ ./gobject/ gsignal. c:3363 do_release (button=0xd447a0, clicked= <optimized out>) buildd/ gtk+3.0- 3.12.2/ ./gtk/gtkbutton .c:1985 button_ released (button=0xd447a0) buildd/ gtk+3.0- 3.12.2/ ./gtk/gtkbutton .c:2103 value=0x0, n_param_values=1, param_values= 0x7fffffffd0d0, hint=0x7fffffff d070) buildd/ glib2.0- 2.40.0/ ./gobject/ gclosure. c:768 emit_unlocked_ R (node=node@ entry=0x64ef40, detail@ entry=0, instance= instance@ entry=0xd447a0, return= emission_ return@ entry=0x0, and_params= instance_ and_params@ entry.. .
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7b34795 in midori_
at /home/evfool/
3008 g_return_
(gdb) backtrace
#0 0x00007ffff7b34795 in midori_
at /home/evfool/
#1 0x00007ffff7b48105 in midori_
button=
at /home/evfool/
#2 0x00007ffff78833b8 in g_closure_invoke (closure=0xde3180,
return_
invocation_
at /build/
#3 0x00007ffff7894d3d in signal_
detail=
emission_
instance_
at /build/
#4 0x00007ffff789ca29 in g_signal_
signal_
var_
at /build/
#5 0x00007ffff789cce2 in g_signal_emit (instance=
signal_
at /build/
---Type <return> to continue, or q <return> to quit---
#6 0x00007ffff78835e7 in _g_closure_
return_
param_
#7 0x00007ffff789c088 in g_signal_
signal_
var_
at /build/
#8 0x00007ffff789cce2 in g_signal_emit (instance=
signal_
at /build/
#9 0x00007ffff6cef8fd in gtk_button_
emit_
at /build/
#10 0x00007ffff6cef943 in gtk_real_
at /build/
#11 0x00007ffff78833b8 in g_closure_invoke (closure=0x64ef10,
return_
invocation_
at /build/
#12 0x00007ffff7894557 in signal_
detail=
emission_
instance_