Code review comment for lp:~elbati/server-env-tools/adding_base_optional_quick_create_7

Revision history for this message
Lorenzo Battistini (elbati) wrote :

On 06/24/2013 11:45 AM, Holger Brunn (Therp) wrote:
> Does this survive a server restart? I'd expect to have to patch BaseModel.__init__ for it to work.

In my tests, it does.
Consider that I followed the same way followed by base_action_rule
<http://bazaar.launchpad.net/%7Eopenerp/openobject-addons/7.0/view/9277/base_action_rule/base_action_rule.py#L132>.

> But then on the other hand, have you considered to patch the many2one widget so that we can set an attribute or a context key to suppress quick create? This seems to me to be more useful as I think you more often need to control that behavior on a per form level and not on a per model level.

This use case (form based) should already be covered by web_m2o_enhanced
<https://github.com/0k/web_m2o_enhanced> module.
But we realized that a per model option would often be more useful.

--
Lorenzo Battistini

« Back to merge proposal