Merge lp:~elbati/server-env-tools/adding_base_optional_quick_create_7 into lp:~server-env-tools-core-editors/server-env-tools/7.0

[Lorenzo Battistini]

This module allows to avoid to 'quick create' new records, through many2one fields, for a specific model.
You can configure which models should allow 'quick create'. When specified, the 'quick create' option will always open the standard create form.

[Holger Brunn (Therp) (hbrunn)]

Does this survive a server restart? I'd expect to have to patch BaseModel.__init__ for it to work.

But then on the other hand, have you considered to patch the many2one widget so that we can set an attribute or a context key to suppress quick create? This seems to me to be more useful as I think you more often need to control that behavior on a per form level and not on a per model level.

review: Needs Information

[Lorenzo Battistini (elbati)]

On 06/24/2013 11:45 AM, Holger Brunn (Therp) wrote:
> Does this survive a server restart? I'd expect to have to patch BaseModel.__init__ for it to work.

In my tests, it does.
Consider that I followed the same way followed by base_action_rule
<http://bazaar.launchpad.net/%7Eopenerp/openobject-addons/7.0/view/9277/base_action_rule/base_action_rule.py#L132>.

> But then on the other hand, have you considered to patch the many2one widget so that we can set an attribute or a context key to suppress quick create? This seems to me to be more useful as I think you more often need to control that behavior on a per form level and not on a per model level.

This use case (form based) should already be covered by web_m2o_enhanced
<https://github.com/0k/web_m2o_enhanced> module.
But we realized that a per model option would often be more useful.

--
Lorenzo Battistini

[Holger Brunn (Therp) (hbrunn)]

Thanks for your comments, approving now

review: Approve

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

LGTM

review: Approve (code review, no test)

=== added directory 'base_optional_quick_create'
=== added file 'base_optional_quick_create/AUTHORS.txt'
--- base_optional_quick_create/AUTHORS.txt	1970-01-01 00:00:00 +0000
+++ base_optional_quick_create/AUTHORS.txt	2013-06-20 09:50:33 +0000
@@ -0,0 +1,1 @@
+Lorenzo Battistini <[e-mail]>

=== added file 'base_optional_quick_create/__init__.py'
--- base_optional_quick_create/__init__.py	1970-01-01 00:00:00 +0000
+++ base_optional_quick_create/__init__.py	2013-06-20 09:50:33 +0000
@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Copyright (C) 2013 Agile Business Group sagl (<http://www.agilebg.com>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+import model

=== added file 'base_optional_quick_create/__openerp__.py'
--- base_optional_quick_create/__openerp__.py	1970-01-01 00:00:00 +0000
+++ base_optional_quick_create/__openerp__.py	2013-06-20 09:50:33 +0000
@@ -0,0 +1,43 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Copyright (C) 2013 Agile Business Group sagl (<http://www.agilebg.com>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': "Optional quick create",
+    'version': '0.1',
+    'category': 'Tools',
+    'description': """
+This module allows to avoid to 'quick create' new records, through many2one fields, for a specific model.
+You can configure which models should allow 'quick create'. When specified, the 'quick create' option will always open the standard create form.
+
+Got the idea from https://twitter.com/nbessi/status/337869826028605441
+""",
+    'author': 'Agile Business Group',
+    'website': 'http://www.agilebg.com',
+    'license': 'AGPL-3',
+    "depends": ['base'],
+    "data": [
+        'model_view.xml',
+    ],
+    "demo": [],
+    'test': [
+    ],
+    "active": False,
+    "installable": True
+}

=== added file 'base_optional_quick_create/model.py'
--- base_optional_quick_create/model.py	1970-01-01 00:00:00 +0000
+++ base_optional_quick_create/model.py	2013-06-20 09:50:33 +0000
@@ -0,0 +1,60 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Copyright (C) 2013 Agile Business Group sagl (<http://www.agilebg.com>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import orm, fields
+from openerp import SUPERUSER_ID
+from openerp.tools.translate import _
+
+class ir_model(orm.Model):
+
+    _inherit = 'ir.model'
+    
+    _columns = {
+        'avoid_quick_create': fields.boolean('Avoid quick create'),
+        }
+
+    def _wrap_name_create(self, old_create, model):
+        def wrapper(cr, uid, name, context=None):
+            raise orm.except_orm(_('Error'), _("Can't create quickly. Opening create form"))
+        return wrapper
+
+    def _register_hook(self, cr, ids=None):
+        if ids is None:
+            ids = self.search(cr, SUPERUSER_ID, [])
+        for model in self.browse(cr, SUPERUSER_ID, ids):
+            if model.avoid_quick_create:
+                model_name = model.model
+                model_obj = self.pool.get(model_name)
+                if not hasattr(model_obj, 'check_quick_create'):
+                    model_obj.name_create = self._wrap_name_create(model_obj.name_create, model_name)
+                    model_obj.check_quick_create = True
+        return True
+
+    def create(self, cr, uid, vals, context=None):
+        res_id = super(ir_model, self).create(cr, uid, vals, context=context)
+        self._register_hook(cr, [res_id])
+        return res_id
+
+    def write(self, cr, uid, ids, vals, context=None):
+        if isinstance(ids, (int, long)):
+            ids = [ids]
+        super(ir_model, self).write(cr, uid, ids, vals, context=context)
+        self._register_hook(cr, ids)
+        return True

=== added file 'base_optional_quick_create/model_view.xml'
--- base_optional_quick_create/model_view.xml	1970-01-01 00:00:00 +0000
+++ base_optional_quick_create/model_view.xml	2013-06-20 09:50:33 +0000
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+        <record id="view_model_form" model="ir.ui.view">
+            <field name="model">ir.model</field>
+            <field name="inherit_id" ref="base.view_model_form"></field>
+            <field name="arch" type="xml">
+                <field name="osv_memory" position="after">
+                    <field name="avoid_quick_create"></field>
+                </field>
+            </field>
+        </record>
+    </data>
+</openerp>