Merge lp:~egormatirov/mpd-sound-menu/mpd-sound-menu into lp:mpd-sound-menu
Proposed by
Mikhail Ivchenko
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Vsevolod Velichko | ||||
Approved revision: | 34 | ||||
Merged at revision: | 32 | ||||
Proposed branch: | lp:~egormatirov/mpd-sound-menu/mpd-sound-menu | ||||
Merge into: | lp:mpd-sound-menu | ||||
Diff against target: |
183 lines (+71/-16) 4 files modified
res/mainwindow.ui (+38/-7) res/mpd-sound-menu.conf (+7/-0) src/mpdconnector.cpp (+16/-9) src/options.cpp (+10/-0) |
||||
To merge this branch: | bzr merge lp:~egormatirov/mpd-sound-menu/mpd-sound-menu | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vsevolod Velichko | Needs Fixing | ||
Review via email: mp+182338@code.launchpad.net |
Description of the change
Add option for choose size of artworks.
Last.fm api key changed because the test API key was deprecated (http://
To post a comment you must log in.
Hi, you have indentation broken in src/options.cpp. Fix it and I'll accept the merge.
Have you thought about the situation when there's no image of required size available? I suppose you need to fetch the lesser one in such situation but in your patch image wouldn't be fetched at all.