Code review comment for lp:~egormatirov/mpd-sound-menu/mpd-sound-menu

Revision history for this message
Vsevolod Velichko (torkvemada) wrote :

Hi, you have indentation broken in src/options.cpp. Fix it and I'll accept the merge.

Have you thought about the situation when there's no image of required size available? I suppose you need to fetch the lesser one in such situation but in your patch image wouldn't be fetched at all.

review: Needs Fixing

« Back to merge proposal