Code review comment for lp:~dylanmccall/harvest/visual-tweaks

Revision history for this message
Dylan McCall (dylanmccall) wrote :

I'm glad you like it :)

Yep, I'm using the font stack suggested in the Ubuntu web guidelines, over here: http://design.canonical.com/the-toolkit/guides-for-websites/

It goes for Ubuntu Beta first, then Deja Vu or Vera, then the default sans-serif font. I didn't put 'Ubuntu' in front of that, just because the web guidelines / ubuntu.com don't do it. It sounds like a fine idea to me, though! Should save us some trouble later on. Thank you!
(Although we should remember to remove 'UbuntuBeta' from the font stack at some point in the future).

I shouldn't change this particular branch (that way when I submit my code next week for the gsoc stuff it won't look like I passed the pencils down time), but I expect it won't cause any trouble. Line 5 just needs to be changed so it says:
font-family:'Ubuntu', 'UbuntuBeta', 'Bitstream Vera Sans', 'DejaVu Sans', Tahoma, sans-serif;

…and line 85 (for what it's worth) needs to be changed to:
font-family:'Molengo', 'Ubuntu', 'Ubuntu Beta', 'DejaVu Sans', 'Bitstream Vera Sans', Tahoma, sans-serif;

« Back to merge proposal