Code review comment for lp:~dyams/unity-2d/update-pips

Revision history for this message
Gerry Boland (gerboland) wrote :

Minor things:

if (!m_application)
   return windowCount;
Doesn't follow our coding guidelines.

QRect desktopRect = ScreenInfo::instance()->geometry() ; <- rogue space character

if (totalWindows && !windowsInCurrentWorkspace) { <- both variables are integers, is clearer to be a liite more verbose: (totalWindows > 0) etc..

Question: Why LauncherItem::belongsToDifferentWorkspace() always returns false?

« Back to merge proposal