Merge lp:~dyams/unity-2d/update-pips into lp:unity-2d

[Lohith D Shivamurthy]

Launcher tile pips are also used to indicate whether the application windows belong to the same workspace(or screen) or not. Now If all windows of an application belong to different workspace(or screen), launcher should indicate the same with an empty triangle(pip) besides the application tile.

[Gerry Boland (gerboland)]

You have some Multi-monitor specific code in this that isn't really quite necessary just now. Just target this MR to indicating if applications are on the current workspace (i.e. visible on all monitors) or not.

[Gerry Boland (gerboland)]

+ objectName: "pips-" + item.name+index

Why do you need this? Won't your test work with

@app.Unity2dPanel() \
.LauncherList( :name => 'main' ) \
.QDeclarativeItem( :name => 'Calculator' ) \
.QDeclarativeImage( :name => 'pips')['source']

[lp:~dyams/unity-2d/update-pips]

852. By Lohith D Shivamurthy on 2012-01-19

[launcher] Part to changes to update pips to indicate apps on different screen is removed.

[Lohith D Shivamurthy (dyams)]

> + objectName: "pips-" + item.name+index
>
> Why do you need this? Won't your test work with
>
> @app.Unity2dPanel() \
> .LauncherList( :name => 'main' ) \
> .QDeclarativeItem( :name => 'Calculator' ) \
> .QDeclarativeImage( :name => 'pips')['source']
No. There can be more than one pip for the same tile. Testability will not identify the objects if they don't have unique object names.

[Gerry Boland (gerboland)]

Aha, the pips are drawn by a repeater, so the original objectName isn't good. Do change it, but still no need for the item.name IMO.

[Gerry Boland (gerboland)]

About your test suite: this makes a big change so it needs several tests.

First off can you please add a good test-description as a comment to the top of each test-case, like
https://bazaar.launchpad.net/~unity-2d-team/unity-2d/trunk/view/head:/tests/launcher/autohide_show_tests.rb

I'd also prefer you split the test cases just a little, so you get tests for:
1. One app on this workspace only
2. One app on other workspace only
3. Two apps on this workspace
4. Two apps, both on other workspace
5. Two apps, one on this workspace, one on other
6. Three apps all on this workspace
7. Three apps, all but one on this workspace
I know it's a lot, but these are all the possible cases that I see your code influencing.

This code isn't perfect:
+ Timeout.timeout(3){XDo::XWindow.wait_for_window('Calculator')}
When you've one calculator open, this will return immediately. It is possible then that
+ return XDo::XWindow.from_active
will return the first calculator XId.

This is the reason I was using terminals with unique titlebars in other tests. At least then you can uniquely identify the window. Hacky, I know. If you know of a way to run a program & get the XId of the window reliably, I'd love to hear it! (via PID is a good idea, except for Terminal:) )

Have a look at tests/misc/lib/tmpwindow.rb (in latest trunk). It also has a cleanup method so that if a test fails, you don't have non-closed windows to worry about. It will mean you can remove "kill" statements from the start of test-cases. Call the cleanup method in the teardown, it's

@number_of_workspaces - this can be a local variable, so no @.

+ width = %x{xrandr --current | grep \'\*+\' | uniq | awk \'{print $1}\' | cut -d \'x\' -f1}
It would be great if you added this to the XDoTool Ruby bindings for everyone to use. Parsing the output with Ruby would probably be quicker?? :)

Small "puts" comments in your test suite are not necessary either. And there's some extra blank lines.

[lp:~dyams/unity-2d/update-pips]

853. By Lohith D Shivamurthy on 2012-01-19

[launcher] Refined objectName for pips

[Gerry Boland (gerboland)]

Minor things:

if (!m_application)
   return windowCount;
Doesn't follow our coding guidelines.

QRect desktopRect = ScreenInfo::instance()->geometry() ; <- rogue space character

if (totalWindows && !windowsInCurrentWorkspace) { <- both variables are integers, is clearer to be a liite more verbose: (totalWindows > 0) etc..

Question: Why LauncherItem::belongsToDifferentWorkspace() always returns false?

[Gerry Boland (gerboland)]

Functionally the code works well and is looking good!

[lp:~dyams/unity-2d/update-pips]

854. By Lohith D Shivamurthy on 2012-01-20

[launcher] Included few review comments

[Lohith D Shivamurthy (dyams)]

> About your test suite: this makes a big change so it needs several tests.
>
> First off can you please add a good test-description as a comment to the top
> of each test-case, like
> https://bazaar.launchpad.net/~unity-2d-team/unity-
> 2d/trunk/view/head:/tests/launcher/autohide_show_tests.rb
>
Done

> I'd also prefer you split the test cases just a little, so you get tests for:
> 1. One app on this workspace only
> 2. One app on other workspace only
> 3. Two apps on this workspace
> 4. Two apps, both on other workspace
> 5. Two apps, one on this workspace, one on other
> 6. Three apps all on this workspace
> 7. Three apps, all but one on this workspace
> I know it's a lot, but these are all the possible cases that I see your code
> influencing.
Actually current test suite considers them all. By Two apps you mean an app with two windows not two different applications. no?
Well, current tests already have separate tests for app with only one window and app with more than one window.
When testing with more than one window, i have also tested by moving each window to different workspace individually.
1) Two windows on current workspace
2) One window on current workspace and another window on different workspace
3) Both windows on different workspace than current

>
>
> This code isn't perfect:
> + Timeout.timeout(3){XDo::XWindow.wait_for_window('Calculator')}
> When you've one calculator open, this will return immediately. It is possible
> then that
> + return XDo::XWindow.from_active
> will return the first calculator XId.
>
There is a 'sleep 2' in between the two statements, which helped me to address the issue you have mentioned.

> This is the reason I was using terminals with unique titlebars in other tests.
> At least then you can uniquely identify the window. Hacky, I know. If you know
> of a way to run a program & get the XId of the window reliably, I'd love to
> hear it! (via PID is a good idea, except for Terminal:) )
I can borrow the same idea. If you don't like the 'sleep 2' :)

>
> Have a look at tests/misc/lib/tmpwindow.rb (in latest trunk). It also has a
> cleanup method so that if a test fails, you don't have non-closed windows to
> worry about. It will mean you can remove "kill" statements from the start of
> test-cases. Call the cleanup method in the teardown, it's
>
No, this kill statements are not for cleaning the residues of the test case. Instead it is a prerequisite. If there are more than one window then pip image is different than when there is only one window. So we need to ensure there is no running windows of the test application.

>
> @number_of_workspaces - this can be a local variable, so no @.
>
If I remove that @ I got this error
.update_pips_tests.rb:62: undefined local variable or method `number_of_workspaces' for #<Class:0xb6e7cbf4> (NameError)

> + width = %x{xrandr --current | grep \'\*+\' | uniq | awk \'{print $1}\' | cut
> -d \'x\' -f1}
> It would be great if you added this to the XDoTool Ruby bindings for everyone
> to use. Parsing the output with Ruby would probably be quicker?? :)
>
This is part of multi-monitor stuff, which is totally removed from this MR already
>
> Small "puts" comment...

[Lohith D Shivamurthy (dyams)]

> Minor things:
>
> if (!m_application)
> return windowCount;
> Doesn't follow our coding guidelines.
>
>
> QRect desktopRect = ScreenInfo::instance()->geometry() ; <- rogue space
> character
>
>
> if (totalWindows && !windowsInCurrentWorkspace) { <- both variables are
> integers, is clearer to be a liite more verbose: (totalWindows > 0) etc..
>
>

Done

>
> Question: Why LauncherItem::belongsToDifferentWorkspace() always returns
> false?

It is virtual funtion, So LauncherApplication::belongsToDifferentWorkspace() is what actually gets called. I don't remember why i returned 'false' from there though.

[Lohith D Shivamurthy (dyams)]

> > Small "puts" comments in your test suite are not necessary either. And
> there's
> > some extra blank lines.
> I have removed 'puts'. I thought they would inform what the test case is doing
> while we are waiting for them to finish. Unfortunately they did serve the
> purpose it seems;)>
I have removed 'puts'. I added them with the intention of informing the nature of tests being executed.
Unfortunately they didn't serve the purpose, it seems :)

[Gerry Boland (gerboland)]

I recommend you make one commit for every comment considered. It makes reviewing your changes easier.

[Gerry Boland (gerboland)]

> Actually current test suite considers them all. By Two apps you mean an app
> with two windows not two different applications. no?
> Well, current tests already have separate tests for app with only one window
> and app with more than one window.
> When testing with more than one window, i have also tested by moving each
> window to different workspace individually.
> 1) Two windows on current workspace
> 2) One window on current workspace and another window on different workspace
> 3) Both windows on different workspace than current

Indeed I noticed that. I just think that each of your test cases are doing too much in one go. Hence I wanted the split.

> > This code isn't perfect:
> > + Timeout.timeout(3){XDo::XWindow.wait_for_window('Calculator')}
> > When you've one calculator open, this will return immediately. It is
> possible
> > then that
> > + return XDo::XWindow.from_active
> > will return the first calculator XId.
> >
> There is a 'sleep 2' in between the two statements, which helped me to address
> the issue you have mentioned.

Helps, but not a cure. We cannot assume the machine isn't slow, we don't want failures because of it.

> I can borrow the same idea. If you don't like the 'sleep 2' :)

Please use the tmpwindow lib. It's a bit safer.

>
> >
> > Have a look at tests/misc/lib/tmpwindow.rb (in latest trunk). It also has a
> > cleanup method so that if a test fails, you don't have non-closed windows to
> > worry about. It will mean you can remove "kill" statements from the start of
> > test-cases. Call the cleanup method in the teardown, it's
> >
> No, this kill statements are not for cleaning the residues of the test case.
> Instead it is a prerequisite. If there are more than one window then pip image
> is different than when there is only one window. So we need to ensure there is
> no running windows of the test application.

Ok, in which case, it should be part of "setup" - or maybe "startup" and then being sure that "teardown" closes all windows created during tests.

> > @number_of_workspaces - this can be a local variable, so no @.
> >
> If I remove that @ I got this error
> .update_pips_tests.rb:62: undefined local variable or method
> `number_of_workspaces' for #<Class:0xb6e7cbf4> (NameError)

Oh you use it in the shutdown, I missed that. Apologies.

> > + width = %x{xrandr --current | grep \'\*+\' | uniq | awk \'{print $1}\' |
> cut
> > -d \'x\' -f1}
> > It would be great if you added this to the XDoTool Ruby bindings for
> everyone
> > to use. Parsing the output with Ruby would probably be quicker?? :)
> >
> This is part of multi-monitor stuff, which is totally removed from this MR
> already

Ok.

> I have removed 'puts'. I thought they would inform what the test case is doing
> while we are waiting for them to finish. Unfortunately they did serve the
> purpose it seems;)

I don't care what test is happening, until it fails, in which case the error tells you what test failed. These comments are nice, but will litter log files, so I prefer to not have them.

[lp:~dyams/unity-2d/update-pips]

855. By Lohith D Shivamurthy on 2012-01-20

[launcher] moved the cleanup and setup code to corresponding functiions

856. By Lohith D Shivamurthy on 2012-01-23

[launcher] split test cases into smalled pieces

857. By Lohith D Shivamurthy on 2012-01-23

[launcher] Refined the method open_window.

[Gerry Boland (gerboland)]

Since we're reviewing a MR for this exact feature to go into shell, this MR is obselete, no?

[Gerry Boland (gerboland)]

This has been merged into shell, so I consider this branch obselete and thus rejecting.

Works well in shell tho, nice work.

review: Disapprove

Unmerged revisions

857. By Lohith D Shivamurthy on 2012-01-23

[launcher] Refined the method open_window.

856. By Lohith D Shivamurthy on 2012-01-23

[launcher] split test cases into smalled pieces

855. By Lohith D Shivamurthy on 2012-01-20

[launcher] moved the cleanup and setup code to corresponding functiions

854. By Lohith D Shivamurthy on 2012-01-20

[launcher] Included few review comments

853. By Lohith D Shivamurthy on 2012-01-19

[launcher] Refined objectName for pips

852. By Lohith D Shivamurthy on 2012-01-19

[launcher] Part to changes to update pips to indicate apps on different screen is removed.

851. By Lohith D Shivamurthy on 2012-01-19

[launcher] Added tests to verify windows on different screen. Using verfy_equal instead of asserts

850. By Lohith D Shivamurthy on 2012-01-17

[launcher] Tests added

849. By Lohith D Shivamurthy on 2012-01-16

[launcher] update pips to indicate whether the application windows belongs to current workspace/screen or not

=== modified file 'launcher/LauncherItem.qml'
--- launcher/LauncherItem.qml	2011-12-21 09:52:15 +0000
+++ launcher/LauncherItem.qml	2012-01-23 06:35:28 +0000
@@ -156,7 +156,7 @@
         Repeater {
             model: item.pips
             delegate: Image {
-                objectName: "pips"
+                objectName: "pips-" + index
                 /* FIXME: It seems that when the image is created (or re-used) by the Repeater
                    for a moment it doesn't have any parent, and therefore warnings are
                    printed for the following two anchor assignements. This fixes the

=== modified file 'launcher/LauncherList.qml'
--- launcher/LauncherList.qml	2011-12-21 09:52:15 +0000
+++ launcher/LauncherList.qml	2012-01-23 06:35:28 +0000
@@ -89,6 +89,16 @@
             }
         }
 
+        function updatePipSource() {
+            if (item.belongsToDifferentWorkspace()) {
+                launcherItem.pips = 1
+                launcherItem.pipSource = "artwork/launcher_arrow_outline_ltr.png";
+            } else {
+                launcherItem.pips = Math.min(item.windowCount, 3)
+                launcherItem.pipSource = ("artwork/launcher_" + ((pips <= 1) ? "arrow" : "pip") + "_ltr.png")
+            }
+        }
+
         Accessible.name: accessibleDescription()
         name: item.name
 
@@ -103,6 +113,7 @@
         urgent: item.urgent
         launching: item.launching
         pips: Math.min(item.windowCount, 3)
+        pipSource: updatePipSource()
 
         counter: item.counter
         counterVisible: item.counterVisible
@@ -286,6 +297,9 @@
         Connections {
             target: item
             onWindowAdded: item.setIconGeometry(x + panel.x, y + panel.y, width, height, xid)
+            onWindowCountChanged: updatePipSource()
+            onWindowWorkspaceChanged: updatePipSource()
+
             /* Not all items are applications. */
             ignoreUnknownSignals: true
         }
@@ -328,5 +342,10 @@
                 }
             }
         }
+
+        Connections {
+            target: declarativeView
+            onActiveWorkspaceChanged: updatePipSource()
+        }
     }
 }

=== added file 'launcher/artwork/launcher_arrow_outline_ltr.png'
Binary files launcher/artwork/launcher_arrow_outline_ltr.png	1970-01-01 00:00:00 +0000 and launcher/artwork/launcher_arrow_outline_ltr.png	2012-01-23 06:35:28 +0000 differ
=== modified file 'libunity-2d-private/src/launcherapplication.cpp'
--- libunity-2d-private/src/launcherapplication.cpp	2012-01-18 11:50:32 +0000
+++ libunity-2d-private/src/launcherapplication.cpp	2012-01-23 06:35:28 +0000
@@ -501,6 +501,8 @@
     for (int i = 0; i < size; ++i) {
         WnckWindow* window = wnck_window_get(xids->at(i));
         wnck_window_set_icon_geometry(window, x, y, width, height);
+        g_signal_connect(G_OBJECT(window), "workspace-changed",
+             G_CALLBACK(LauncherApplication::windowWorkspaceChangedCB), this);
     }
 }
 
@@ -599,6 +601,11 @@
 LauncherApplication::windowCountOnCurrentWorkspace()
 {
     int windowCount = 0;
+
+    if (!m_application) {
+        return windowCount;
+    }
+
     WnckWorkspace *current = wnck_screen_get_active_workspace(wnck_screen_get_default());
 
     QScopedPointer<BamfWindowList> windows(m_application->windows());
@@ -937,6 +944,18 @@
     } 
 }
 
+bool
+LauncherApplication::belongsToDifferentWorkspace()
+{
+    int totalWindows = windowCount();
+    int windowsInCurrentWorkspace = windowCountOnCurrentWorkspace();
+    if (totalWindows > 0 && windowsInCurrentWorkspace == 0) {
+        return true;
+    }
+
+    return false;
+}
+
 void
 LauncherApplication::onIndicatorMenuUpdated()
 {
@@ -1053,4 +1072,17 @@
     setDynamicQuicklistImporter(newOwner);
 }
 
+void
+LauncherApplication::windowWorkspaceChangedCB(WnckWindow *window, gpointer user_data)
+{
+    Q_UNUSED(window);
+    ((LauncherApplication*)user_data)->updateWindowWorkspaceChanged();
+}
+
+void
+LauncherApplication::updateWindowWorkspaceChanged()
+{
+    Q_EMIT windowWorkspaceChanged();
+}
+
 #include "launcherapplication.moc"

=== modified file 'libunity-2d-private/src/launcherapplication.h'
--- libunity-2d-private/src/launcherapplication.h	2012-01-13 15:05:44 +0000
+++ libunity-2d-private/src/launcherapplication.h	2012-01-23 06:35:28 +0000
@@ -104,6 +104,7 @@
     Q_INVOKABLE virtual void launchNewInstance();
 
     Q_INVOKABLE virtual void createMenuActions();
+    Q_INVOKABLE virtual bool belongsToDifferentWorkspace();
 
     void updateOverlaysState(const QString& sender, const QMap<QString, QVariant>& properties);
 
@@ -174,6 +175,9 @@
     bool updateOverlayState(const QMap<QString, QVariant>& properties,
                             const QString& propertyName, T* member);
 
+    static void windowWorkspaceChangedCB(WnckWindow *window, gpointer user_data);
+    void updateWindowWorkspaceChanged();
+
     QString m_dynamicQuicklistPath;
     QScopedPointer<DBusMenuImporter> m_dynamicQuicklistImporter;
     QDBusServiceWatcher* m_dynamicQuicklistServiceWatcher;

=== modified file 'libunity-2d-private/src/launcheritem.cpp'
--- libunity-2d-private/src/launcheritem.cpp	2011-07-29 13:49:34 +0000
+++ libunity-2d-private/src/launcheritem.cpp	2012-01-23 06:35:28 +0000
@@ -87,6 +87,12 @@
 }
 
 bool
+LauncherItem::belongsToDifferentWorkspace()
+{
+    return false;
+}
+
+bool
 LauncherItem::progressBarVisible() const
 {
     return false;

=== modified file 'libunity-2d-private/src/launcheritem.h'
--- libunity-2d-private/src/launcheritem.h	2011-07-29 13:49:34 +0000
+++ libunity-2d-private/src/launcheritem.h	2012-01-23 06:35:28 +0000
@@ -79,6 +79,7 @@
     Q_INVOKABLE virtual void activate() = 0;
     Q_INVOKABLE virtual void createMenuActions() = 0;
     Q_INVOKABLE virtual void launchNewInstance();
+    Q_INVOKABLE virtual bool belongsToDifferentWorkspace();
 
 protected:
     LauncherContextualMenu* m_menu;
@@ -100,6 +101,7 @@
     void counterChanged(int);
     void emblemVisibleChanged(bool);
     void emblemChanged(QString);
+    void windowWorkspaceChanged();
 
 public Q_SLOTS:
     /* Default implementation of drag’n’drop handling, should be overridden in

=== modified file 'libunity-2d-private/src/unity2ddeclarativeview.cpp'
--- libunity-2d-private/src/unity2ddeclarativeview.cpp	2011-12-08 19:41:38 +0000
+++ libunity-2d-private/src/unity2ddeclarativeview.cpp	2012-01-23 06:35:28 +0000
@@ -263,6 +263,7 @@
 void Unity2DDeclarativeView::onActiveWorkspaceChanged() 
 {
     m_last_focused_window = None;
+    Q_EMIT activeWorkspaceChanged();
 }
 
 #include <unity2ddeclarativeview.moc>

=== modified file 'libunity-2d-private/src/unity2ddeclarativeview.h'
--- libunity-2d-private/src/unity2ddeclarativeview.h	2011-12-08 19:41:38 +0000
+++ libunity-2d-private/src/unity2ddeclarativeview.h	2012-01-23 06:35:28 +0000
@@ -44,6 +44,7 @@
     void useOpenGLChanged(bool);
     void transparentBackgroundChanged(bool);
     void globalPositionChanged(QPoint);
+    void activeWorkspaceChanged();
 
 protected:
     void setupViewport();

=== added file 'tests/launcher/update_pips_tests.rb'
--- tests/launcher/update_pips_tests.rb	1970-01-01 00:00:00 +0000
+++ tests/launcher/update_pips_tests.rb	2012-01-23 06:35:28 +0000
@@ -0,0 +1,291 @@
+#!/usr/bin/env ruby1.8
+=begin
+/*
+ * This file is part of unity-2d
+ *
+ * Copyright 2011 Canonical Ltd.
+ *
+ * Authors:
+ * - Lohith DS <[e-mail]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+=end
+
+require '../run-tests.rb' unless $INIT_COMPLETED
+require 'xdo/xwindow'
+require 'xdo/keyboard'
+require 'xdo/mouse'
+require 'timeout'
+require 'tmpdir'
+
+def open_window()
+    window_id = -1
+    o =  [('a'..'z'),('A'..'Z')].map{|i| i.to_a}.flatten;
+    title_string  =  (0..50).map{ o[rand(o.length)]  }.join;
+    if (@@title_string.empty?)
+        @@title_string = title_string
+    end
+    title_string = title_string
+    puts (title_string)
+    # Open xman with random title
+    system "xman -title #{title_string} &"
+    Timeout.timeout(30){ window_id = XDo::XWindow.wait_for_window(title_string)}
+    Kernel.raise(SystemCallError, "Unable to open xman") if window_id == -1
+    return XDo::XWindow.new(window_id)
+end
+
+def change_window_workspace(xid)
+    new_workspace = 0
+    if xid.desktop > 0
+        new_workspace=0
+    else
+        new_workspace=1
+    end
+
+    xid.desktop=new_workspace
+    verify_true(10, 'Change window workspace failed') {
+        xid.desktop==new_workspace
+    }
+end
+
+def reset_current_workspace
+    XDo::XWindow.desktop=@@current_workspace
+    verify_true(10, 'Reset active workspace failed') {
+        XDo::XWindow.desktop==@@current_workspace
+    }
+end
+
+############################# Test Suite #############################
+context "Launcher pips tests" do
+  # Run once at the beginning of this test suite
+  startup do
+    system 'killall unity-2d-launcher > /dev/null 2>&1'
+    system 'killall unity-2d-launcher > /dev/null 2>&1'
+
+    # Minimize all windows
+    XDo::XWindow.toggle_minimize_all
+
+    @number_of_workspaces = XDo::XWindow.desktop_num
+    @reset_num_workspaces = false
+    if @number_of_workspaces < 2
+        puts ("Setting number of workspaces to minimum(two) to enable the test suite")
+        XDo::XWindow.desktop_num = 2
+        @reset_num_workspaces = true
+    end
+
+    system 'killall xman > /dev/null 2>&1'
+    @@current_workspace = XDo::XWindow.desktop
+    @@title_string = ""
+    @@xid_list=Array.new
+
+  end
+  
+  # Run once at the end of this test suite
+  shutdown do
+    if @reset_num_workspaces == true
+        puts ("\nResetting number of workspaces to " + @number_of_workspaces.to_s )
+        XDo::XWindow.desktop_num=@number_of_workspaces
+    end
+    @@xid_list.each {
+        |xid|
+        if (xid.exists?)
+            xid.close!
+        end
+    }
+  end
+
+  # Run before each test case begins
+  setup do
+    #Ensure mouse out of the way
+
+    # Execute the application 
+    @sut = TDriver.sut(:Id => "sut_qt")    
+    @app = @sut.run( :name => UNITY_2D_LAUNCHER, 
+    		         :arguments => "-testability", 
+    		         :sleeptime => 2 )
+    # Make certain application is ready for testing
+    verify(10){ @app.Unity2dPanel() }
+
+  end
+
+  # Run after each test case completes
+  teardown do
+    reset_current_workspace
+    #@app.close        
+    #Need to kill Launcher as it does not shutdown when politely asked
+    system "pkill -nf unity-2d-launcher"
+  end
+
+    #####################################################################################
+    # Test cases
+
+    # Test case objectives:
+    #   * Check pips are updated properly when the app is in current workspace
+    #   *
+    # Pre-conditions
+    #   * This test case assumes that the test app will have only one window
+    #   * For eg, xman is choosen
+    #   * To ensure there is calculator windows running, kill all the calculator windows if any
+    #   *
+    # Test steps
+    #   * Open a calculator window
+    #   * Verify the launcher tile pip image matches with the expected one
+    #   *
+    # Post-conditions
+    #   *   Reset the current workspace to initial workspace
+    #   *
+    # References
+    #   * lp:#883172
+    #   *
+
+    test "Update launcher pips to indicate a window in current workspace" do
+        xid = open_window()
+        @@xid_list << xid
+
+        expected_pip_image = 'image://blended/artwork/launcher_arrow_ltr.pngcolor=lightgreyalpha=1'
+
+        verify_equal(expected_pip_image, 10, 'pip not matching with launcher_arrow_ltr.png'){
+             @app.Unity2dPanel() \
+            .LauncherList( :name => 'main' ) \
+            .QDeclarativeItem( :name => @@title_string ) \
+            .QDeclarativeImage( :name => 'pips-0')['source']
+        }
+    end
+
+    # Test case objectives:
+    #   * Check pips are updated properly when the app is moved to different workspace
+    #   *
+    # Pre-conditions
+    #   * The same window created in above test-case is re-used
+    #   *
+    # Test steps
+    #   * Move the window to a differnt workspace
+    #   * Verify the launcher tile pip image matches with the expected one
+    #   *
+    # Post-conditions
+    #   * Reset the current workspace to initial workspace
+    #   *
+    # References
+    #   * lp:#883172
+    #   *
+    test "Update launcher pips to indicate an app that belongs to different workspace" do
+        xid = @@xid_list[0]
+
+        change_window_workspace(xid)
+
+        expected_pip_image =  'image://blended/artwork/launcher_arrow_outline_ltr.pngcolor=lightgreyalpha=1'
+
+        verify_equal(expected_pip_image, 10, 'pip not matching with launcher_arrow_outline_ltr.png'){
+             @app.Unity2dPanel() \
+            .LauncherList( :name => 'main' ) \
+            .QDeclarativeItem( :name => @@title_string ) \
+            .QDeclarativeImage( :name => 'pips-0')['source']
+        }
+    end
+
+    # Test case objectives:
+    #   * Check pips are updated properly with app with more than one window
+    #   *
+    # Pre-conditions
+    #   * The same window created in first test case is re-used
+    #   *
+    # Test steps
+    #   * Open another window alogn with first window from the testcase one.
+    #   * Verify the launcher tile pip images matches with the expected one
+    #   *
+    # Post-conditions
+    #   * Reset the current workspace to initial workspace
+    #   *
+    # References
+    #   * lp:#883172
+    #   *
+
+    test "Update launcher pips to indicate an app with two windows on two different workspaces" do
+        xid = open_window()
+        @@xid_list << xid
+
+        expected_pip_image = 'image://blended/artwork/launcher_pip_ltr.pngcolor=lightgreyalpha=1'
+
+        verify_equal(expected_pip_image, 10, 'Pip not matching expected image launcher_pip_ltr.png'){
+             @app.Unity2dPanel() \
+            .LauncherList( :name => 'main' ) \
+            .QDeclarativeItem( :name => @@title_string ) \
+            .QDeclarativeImage( :name => 'pips-0')['source']
+        }
+    end
+
+    # Test case objectives:
+    #   * Check pips are updated properly when the app is moved to another workspace
+    #   *
+    # Pre-conditions
+    #   * The same windows created above are re-used
+    #   *
+    # Test steps
+    #   * Move the second window too to a differnt workspace
+    #   * Verify the launcher tile pip image matches with the expected one
+    #   *
+    # Post-conditions
+    #   * Reset the current workspace to initial workspace
+    #   *
+    # References
+    #   * lp:#883172
+    #   *
+    test "Update launcher pips to indicate an app completely belonging to different workspace." do
+        xid1= @@xid_list[1]
+
+        change_window_workspace(xid1)
+
+        expected_pip_image = 'image://blended/artwork/launcher_arrow_outline_ltr.pngcolor=lightgreyalpha=1'
+
+        verify_equal(expected_pip_image, 10, 'pip not matching expected image launcher_arrow_outline_ltr.png'){
+             @app.Unity2dPanel() \
+            .LauncherList( :name => 'main' ) \
+            .QDeclarativeItem( :name => @@title_string ) \
+            .QDeclarativeImage( :name => 'pips-0')['source']
+        }
+    end
+
+    # Test case objectives:
+    #   * Check pips are updated properly when the app is moved to another workspace
+    #   *
+    # Pre-conditions
+    #   * The same windows created above are resued.
+    #   *
+    # Test steps
+    #   * Close one of the app window and move the last window back to its original workspace
+    #   * Verify the launcher tile pip image matches with the expected one
+    #   *
+    # Post-conditions
+    #   * Reset the current workspace to initial workspace
+    #   *
+    # References
+    #   * lp:#883172
+    #   *
+    test "Update launcher pips to indicate when a app window is closed." do
+        xid0 = @@xid_list[0]
+        xid1 = @@xid_list[1]
+
+        xid1.close!
+        change_window_workspace(xid0)
+
+        expected_pip_image = 'image://blended/artwork/launcher_arrow_outline_ltr.pngcolor=lightgreyalpha=1'
+
+        verify_equal(expected_pip_image, 10, 'pip not matching expected image launcher_arrow_outline_ltr.png'){
+             @app.Unity2dPanel() \
+            .LauncherList( :name => 'main' ) \
+            .QDeclarativeItem( :name => @@title_string ) \
+            .QDeclarativeImage( :name => 'pips-0')['source']
+        }
+    end
+end