Code review comment for lp:~dyams/unity-2d/dash-filter-checkoptions-scrollable
Revision history for this message
| Gerry Boland (gerboland) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
f33e652
(Get the code!)
Well the real problem is that the GridViewWithSpacing vertically higher than the space allocated to it.
When you make a grid with more than one row of items, the grid has padding of size verticalSpacing after the last row. A workaround was to remove this from the height, but that causes the grid to scroll.
Solving this would also fix the issue with the Last Modified line.
I believe your fix isn't correct also in the case of keyboard navigation, as when you highlight an item in the last row, the grid will still scroll.