Merge lp:~dyams/unity-2d/dash-filter-checkoptions-scrollable into lp:unity-2d

[Lohith D Shivamurthy]

[Dash] Fixes scrollable filter-check-options

[Lohith D Shivamurthy (dyams)]

The visual difference before and after the changes can be found here
http://ubuntuone.com/3sWQzBFvczxUE2jJF7ET6y
http://ubuntuone.com/4S2YgvS5CPvtZacB03k1mN
http://ubuntuone.com/1G20Ojs85EpGACqfuw7EdW
http://ubuntuone.com/6Jk14WxwAP8rq8TnirlTHo
http://ubuntuone.com/7Be0PWIo1MvUN7WXvre90A

[Lohith D Shivamurthy (dyams)]

dash-apps-sources.before.png > http://ubuntuone.com/3sWQzBFvczxUE2jJF7ET6y
dash-apps-type-after.png > http://ubuntuone.com/4S2YgvS5CPvtZacB03k1mN
dash-apps-type-before.png > http://ubuntuone.com/1G20Ojs85EpGACqfuw7EdW
dash-files&folders-after.png > http://ubuntuone.com/6Jk14WxwAP8rq8TnirlTHo
dash-files&folders-before.png > http://ubuntuone.com/7Be0PWIo1MvUN7WXvre90A

[Michał Sawicz (saviq)]

review: Approve

[Gerry Boland (gerboland)]

This unfortunately breaks keyboard navigation of the checkboxes.

review: Needs Fixing

[Lohith D Shivamurthy (dyams)]

> This unfortunately breaks keyboard navigation of the checkboxes.
Grr. Its a bug in Qt it seems.
https://bugreports.qt-project.org/browse/QTBUG-17051

[lp:~dyams/unity-2d/dash-filter-checkoptions-scrollable]

920. By Lohith D Shivamurthy on 2012-02-20

Workaround to stop scrolling

[Gerry Boland (gerboland)]

Well the real problem is that the GridViewWithSpacing vertically higher than the space allocated to it.

When you make a grid with more than one row of items, the grid has padding of size verticalSpacing after the last row. A workaround was to remove this from the height, but that causes the grid to scroll.

Solving this would also fix the issue with the Last Modified line.

I believe your fix isn't correct also in the case of keyboard navigation, as when you highlight an item in the last row, the grid will still scroll.

[Gerry Boland (gerboland)]

Branch abandoned, rejecting.

Unmerged revisions

920. By Lohith D Shivamurthy on 2012-02-20

Workaround to stop scrolling

919. By Lohith D Shivamurthy on 2012-02-17

[Dash] Fixes scrollable filter-check-options

=== modified file 'shell/dash/FilterCheckoption.qml'
--- shell/dash/FilterCheckoption.qml	2012-01-10 16:52:24 +0000
+++ shell/dash/FilterCheckoption.qml	2012-02-20 06:52:19 +0000
@@ -30,6 +30,8 @@
                   || filterView.filterModel.id == "modified" ) ? 3 : 2
         rows: Math.ceil(count/columns)
 
+        maximumFlickVelocity: 0.0 /* Workaround to stop scrolling */
+
         horizontalSpacing: 10
         verticalSpacing: 14