Merge lp:~dpniel/ubiquity/fix-1480430 into lp:ubiquity

[Dan Chapman ]

[Autopilot tests] Add workaround for write changes to disk dialog

Unfortunately the dialog buttons have not identifiable properties to be
able to select and click the continue button. So this patch resorts to
a lengthy sleep and keyboard navigation to continue the install.

I will file a separate bug about improving autopilot accessibility of
this dialog as it would mean a change happening in ubiquity itself which
I don't want to include in this commit

[lp:~dpniel/ubiquity/fix-1480430]

6314. By Dan Chapman  on 2015-09-05

Fix pep8 warnings

[Nicholas Skaggs (nskaggs)]

Dan, can you comment on the bug you filed for this issue? It would be nice to include it in the comments.

review: Approve

[Mathieu Trudel-Lapierre (cyphermox)]

Could we not instead provide you a name for that button? Seems like it would be a more solid fix than pressing keys, even if this would work.

I'm happy to take changes to the UI, you don't need to limit yourself to autopilot integration :)

review: Needs Information

[Dan Chapman  (dpniel)]

After our IRC discussion i've dug into this a little more to refresh my memory. So when the buttons are added to the dialog[1] it's done using gtk.Dialog.add_button() [2].

With this approach I can't see any way that set_name() can be called on each button as the add_button takes care of creation for you with no option to add a name.

I'm happy to try and make changes to the UI with a bit of guidance on what would be the best approach to get name properties on the buttons

[1] http://bazaar.launchpad.net/~ubuntu-installer/ubiquity/trunk/view/head:/ubiquity/frontend/gtk_ui.py#L1789
[2] https://lazka.github.io/pgi-docs/#Gtk-3.0/classes/Dialog.html#Gtk.Dialog.add_button

[Mathieu Trudel-Lapierre (cyphermox)]

I'm fine with dealing with it as-is for now. Now wouldn't be the time to rewrite parts of the installer.

I filed https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1495581 so as not to forget to fix this better.

review: Approve

=== modified file 'autopilot/ubiquity_autopilot_tests/tests/__init__.py'
--- autopilot/ubiquity_autopilot_tests/tests/__init__.py	2014-06-30 13:09:16 +0000
+++ autopilot/ubiquity_autopilot_tests/tests/__init__.py	2015-09-05 12:56:13 +0000
@@ -113,6 +113,25 @@
         nxt_button.click()
 
         if wait:
+            # When the test clicks "Install now" a confirm overwrite disk
+            # dialog appears. This is an "ubi_question_dialog" and although
+            # we can grab it with autopilot we cannot easily select the
+            # continue button as it has no name or BuilderName properties
+            # There are two buttons that basically have identical xpaths
+            # so even identifying the correct button is not really possible.
+            # We experience the same during the manual partition step when
+            # creating a new table. The dialog seems to be a generic msg dialog
+            # that's created on the fly so we can't even add those properties.
+            # The best we can do here is a bit of damage limitation and use a
+            # lengthy sleep and keyboard right to the continue button.
+            print("go_to_next_page() Entering workaround "
+                  "for ubi_question_dialog")
+            print("If the test failed here it is most likely a timing issue")
+            # This maybe overkill but better to be safe
+            time.sleep(20)
+            self.kbd.press_and_release('Right')
+            self.kbd.press_and_release('Enter')
+            print("Workaround ended continuing with wait for next step")
             # This sleep just bridges a weird error when the next button,
             # sometimes flickers its sensitive property back to 1 once clicked
             # and then goes back to 0