This looks nice and simple, but ideally we should either include here
the changes to startBuild() to match the callsite in master/models.py or
leave out the callsite changes. Either way is fine with me.
Also, something I should've noticed earlier is that the length
constraint on lp_user might hurt us down the road because LP doesn't
impose any restrictions on the length of usernames (they use text as the
column type). It might not be a big deal as we can always ask people to
change the usernames in LP, but unless we have a good reason to restrict
their length in offspring I think it'd be better to avoid it.
With those two small changes you can just commit to the private-builds
integration branch; no need to resubmit the proposal.
Hi James,
This looks nice and simple, but ideally we should either include here
the changes to startBuild() to match the callsite in master/models.py or
leave out the callsite changes. Either way is fine with me.
Also, something I should've noticed earlier is that the length
constraint on lp_user might hurt us down the road because LP doesn't
impose any restrictions on the length of usernames (they use text as the
column type). It might not be a big deal as we can always ask people to
change the usernames in LP, but unless we have a good reason to restrict
their length in offspring I think it'd be better to avoid it.
With those two small changes you can just commit to the private-builds
integration branch; no need to resubmit the proposal.
Cheers,