Merge lp:~dooferlad/offspring/ssh_user_key into lp:~linaro-automation/offspring/private-builds

Proposed by James Tunnicliffe on 2011-10-18
Status: Merged
Merged at revision: 65
Proposed branch: lp:~dooferlad/offspring/ssh_user_key
Merge into: lp:~linaro-automation/offspring/private-builds
Diff against target: 0 lines
To merge this branch: bzr merge lp:~dooferlad/offspring/ssh_user_key
Reviewer Review Type Date Requested Status
Linaro Infrastructure 2011-10-18 Pending
Review via email: mp+79730@code.launchpad.net

Description of the change

Adding lp_user and lp_ssh_key to the database. Comes with migration script.

To post a comment you must log in.
Guilherme Salgado (salgado) wrote :

Hi James,

This looks nice and simple, but ideally we should either include here
the changes to startBuild() to match the callsite in master/models.py or
leave out the callsite changes. Either way is fine with me.

Also, something I should've noticed earlier is that the length
constraint on lp_user might hurt us down the road because LP doesn't
impose any restrictions on the length of usernames (they use text as the
column type). It might not be a big deal as we can always ask people to
change the usernames in LP, but unless we have a good reason to restrict
their length in offspring I think it'd be better to avoid it.

With those two small changes you can just commit to the private-builds
integration branch; no need to resubmit the proposal.

Cheers,

lp:~dooferlad/offspring/ssh_user_key updated on 2011-10-19
61. By James Tunnicliffe on 2011-10-19

Reverting change to startBuild for this merge.

62. By James Tunnicliffe on 2011-10-19

Modified lp_user field to match the Launchpad implementation.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches