Code review comment for lp:~donadigo/wingpanel/fix-side-popover-expanding

Revision history for this message
Djax (parnold-x) wrote :

Not sure on this. Do you really need a new signal? The set_expand method should handle the expanding and shrinking. If something in update_panel_dimension is needed in addition this should be added to the expand method.
Also as rico mentioned you reverted the code for following the primary monitor on two display setups. Was this intentional?

review: Needs Information

« Back to merge proposal