Merge lp:~donadigo/wingpanel/fix-side-popover-expanding into lp:~wingpanel-devs/wingpanel/trunk

[Adam Bieńkowski]

* Fix rare side expanding popovers.

Fixes rare side expanding popovers.

To reproduce, open the indicator first time after the wingpanel loaded, and it should expand only to the side as having no space to show all of it's contents, if it didn't work, just restart wingpanel to try again.

This branch just makes sure that after setting visible_popover variable the update_panel_dimensions is called so the popover is ready to show and expand.

[Rico Tzschichholz (ricotz)]

Reverting https://bazaar.launchpad.net/~wingpanel-devs/wingpanel/trunk/revision/127 !?!?

[Kirill Romanov (djaler1)]

I tested this branch. It works well, the problem is resolved.

review: Approve (excellent)

[Djax (parnold-x)]

Not sure on this. Do you really need a new signal? The set_expand method should handle the expanding and shrinking. If something in update_panel_dimension is needed in addition this should be added to the expand method.
Also as rico mentioned you reverted the code for following the primary monitor on two display setups. Was this intentional?

review: Needs Information

[Adam Bieńkowski (donadigo)]

I did not revert anything, I just made the changes to the branch, and commited. I don't know why this happened.

[Rico Tzschichholz (ricotz)]

Better redo this branch and make sure to commit only the intended changes.

[lp:~donadigo/wingpanel/fix-side-popover-expanding]

129. By Adam Bieńkowski on 2016-06-19

Fix rare expanding popover to the side

[Adam Bieńkowski (donadigo)]

Branch redone & updated to djax's suggestions.

[Djax (parnold-x)]

Code looks good. I can't reproduce the origin problem so if this fixes it I would say go merge it.

review: Approve (code)

[Danielle Foré (danrabbit)]

As far as I can tell, this works as intended. I can't reproduce the issue any longer.

review: Approve

[Kirill Romanov (djaler1)]

review: Approve

=== modified file 'src/PanelWindow.vala'
--- src/PanelWindow.vala	2016-06-13 13:54:25 +0000
+++ src/PanelWindow.vala	2016-06-19 10:49:02 +0000
@@ -151,10 +151,6 @@
     }
 
     public void set_expanded (bool expanded) {
-        if (this.expanded == expanded) {
-            return;
-        }
-
         if (expanded) {
             Services.BackgroundManager.get_default ().remember_window ();