Code review comment for lp:~doflah/ubuntu-calendar-app/fix_daylight_savings

Revision history for this message
David Planella (dpm) wrote :

On Tue, Sep 3, 2013 at 1:43 PM, Olivier Tilloy <<email address hidden>
> wrote:

> > Yeah, I could definitely look into that. What should I be using to
> write the
> > tests, Autopilot?
>
> No, I was thinking more of headless unit tests (autopilot is for UI
> integration tests). We could probably leverage QtQuickTest (see
> http://qt-project.org/doc/qt-5.0/qtquick/qtquick2-qtquick-qtquicktest.htmlfor documentation).
>
>
The Calculator app has got some unit tests that can be used as an example:
http://bazaar.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/trunk/files/head:/unit-tests/

They can be run locally, but at some point we'll need to get Jenkins to run
them as well.

>
> > Also, what did I do to make Jenkins unhappy?
>
> Nothing. The failures are unrelated to your change. It appears there was
> an API change in the UITK that went in without notice, and it broke a
> number of applications’ tests. The change has now been reverted, once the
> new packages are propagated I’ll request a re-run.
> --
>
> https://code.launchpad.net/~dennis-oflaherty/ubuntu-calendar-app/fix_daylight_savings/+merge/183557
> Your team Ubuntu Calendar Developers is subscribed to branch
> lp:ubuntu-calendar-app.
>

« Back to merge proposal