Merge lp:~doflah/ubuntu-calendar-app/fix_daylight_savings into lp:ubuntu-calendar-app

[Dennis O'Flaherty]

Fix the implementation of Date.addDays() wrt DST.

The current implementation of Date#addDays breaks in daylight savings time.

    var d = new Date(2013, 9, 27);
    d.addDays(7).toString(); // "Sun Nov 03 2013 00:00:00 GMT-0400 (EST)"
    d.addDays(8).toString(); // "Sun Nov 03 2013 23:00:00 GMT-0500 (EST)"

so November has two 3rds. This is too many. Using setDate and getDate results in the expected behavior.

    var d = new Date(2013, 9, 27);
    d.addDays(7).toString(); // "Sun Nov 03 2013 00:00:00 GMT-0400 (EST)"
    d.addDays(8).toString(); // "Mon Nov 04 2013 00:00:00 GMT-0500 (EST)"

[Olivier Tilloy (osomon)]

Good catch Dennis, thanks for the patch!

review: Approve

[Olivier Tilloy (osomon)]

I keep meaning to add unit tests for the JS libraries, but never actually get around to doing it.
Dennis, any chance you’d be interested in setting up such tests?

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/9/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/163
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-precise-amd64-autolanding/9
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-quantal-amd64-autolanding/9
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-autolanding/9
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-autolanding/9

review: Needs Fixing (continuous-integration)

[Dennis O'Flaherty (doflah)]

Yeah, I could definitely look into that. What should I be using to write the tests, Autopilot?

Also, what did I do to make Jenkins unhappy?

[Olivier Tilloy (osomon)]

> Yeah, I could definitely look into that. What should I be using to write the
> tests, Autopilot?

No, I was thinking more of headless unit tests (autopilot is for UI integration tests). We could probably leverage QtQuickTest (see http://qt-project.org/doc/qt-5.0/qtquick/qtquick2-qtquick-qtquicktest.html for documentation).

> Also, what did I do to make Jenkins unhappy?

Nothing. The failures are unrelated to your change. It appears there was an API change in the UITK that went in without notice, and it broke a number of applications’ tests. The change has now been reverted, once the new packages are propagated I’ll request a re-run.

[David Planella (dpm)]

On Tue, Sep 3, 2013 at 1:43 PM, Olivier Tilloy <<email address hidden>
> wrote:

> > Yeah, I could definitely look into that. What should I be using to
> write the
> > tests, Autopilot?
>
> No, I was thinking more of headless unit tests (autopilot is for UI
> integration tests). We could probably leverage QtQuickTest (see
> http://qt-project.org/doc/qt-5.0/qtquick/qtquick2-qtquick-qtquicktest.htmlfor documentation).
>
>
The Calculator app has got some unit tests that can be used as an example:
http://bazaar.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/trunk/files/head:/unit-tests/

They can be run locally, but at some point we'll need to get Jenkins to run
them as well.

>
> > Also, what did I do to make Jenkins unhappy?
>
> Nothing. The failures are unrelated to your change. It appears there was
> an API change in the UITK that went in without notice, and it broke a
> number of applications’ tests. The change has now been reverted, once the
> new packages are propagated I’ll request a re-run.
> --
>
> https://code.launchpad.net/~dennis-oflaherty/ubuntu-calendar-app/fix_daylight_savings/+merge/183557
> Your team Ubuntu Calendar Developers is subscribed to branch
> lp:ubuntu-calendar-app.
>

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'dateExt.js'
--- dateExt.js	2013-08-17 03:29:15 +0000
+++ dateExt.js	2013-09-03 02:08:30 +0000
@@ -37,7 +37,7 @@
 
 Date.prototype.addDays = function(days) {
     var date = new Date(this)
-    date.setTime(date.getTime() + Date.msPerDay * days)
+    date.setDate(date.getDate() + days);
     return date
 }