Ubuntu Calendar App

Code review comment for lp:~doflah/ubuntu-calendar-app/fix_daylight_savings

  1. fix_daylight_savings
  2. Merge into trunk
Revision history for this message
Olivier Tilloy (osomon) wrote :

> Yeah, I could definitely look into that. What should I be using to write the
> tests, Autopilot?

No, I was thinking more of headless unit tests (autopilot is for UI integration tests). We could probably leverage QtQuickTest (see http://qt-project.org/doc/qt-5.0/qtquick/qtquick2-qtquick-qtquicktest.html for documentation).

> Also, what did I do to make Jenkins unhappy?

Nothing. The failures are unrelated to your change. It appears there was an API change in the UITK that went in without notice, and it broke a number of applications’ tests. The change has now been reverted, once the new packages are propagated I’ll request a re-run.

« Back to merge proposal