Code review comment for lp:~doanac/utah/client-repeat_count

Revision history for this message
Andy Doan (doanac) wrote :

On 04/08/2013 01:09 PM, Max Brustkern wrote:
>> > and the YAML record for each time gets a repeat count number that
>> >indicates the number of times after the run that the test should be
>> >repeated,
>> >
>> >no - you just have an array of these in the yaml.
> Okay, I think I'm confused by the fact that we're calling runner.run(x) for a range of values, but runner is also doing self.repeat_count-=1 and not just relying on the x. Maybe I need to run it to look at the output and understand.

I'll admit this feels a little awkward. The thing to keep in mind is
that we have to know the *first* time something is run (ie rerun =
False) and also how many times to run it. So you need two variables. I'm
using "iteration" to let us know which run we are doing and, if its 0
know rerun=False. "repeat_count" is used to know how how high
"iterations" should go to and gets persisted.

« Back to merge proposal