UTAH

Merge lp:~doanac/utah/client-repeat_count into lp:utah

client-repeat_count
Merge into dev

Proposed by Andy Doan on 2013-04-04

Status:	Superseded
Proposed branch:	lp:~doanac/utah/client-repeat_count
Merge into:	lp:utah
Diff against target:	0 lines
To merge this branch:	bzr merge lp:~doanac/utah/client-repeat_count
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
UTAH Dev		2013-04-04	Pending
Review via email: mp+157168@code.launchpad.net

This proposal has been superseded by a proposal from 2013-05-23.

Description of the change

These are the changes needed to allow utah to honor the "repeat_count" attribute in a run list. I also made some small fixes in the last 2 revno's for issues I found on the nexus.

This change set is probably easiest to read if no go revno by revno rather than trying to read the whole thing at once.

Revision history for this message

Max Brustkern (nuclearbob) wrote on 2013-04-08:

So when repeat_count is nonzero, we repeat that many times, and the YAML record for each time gets a repeat count number that indicates the number of times after the run that the test should be repeated, unless one run fails, in which case we stop, and don't repeat?

Revision history for this message

Andy Doan (doanac) wrote on 2013-04-08:

On 04/08/2013 09:32 AM, Max Brustkern wrote:
> So when repeat_count is nonzero, we repeat that many times,

yes

> and the YAML record for each time gets a repeat count number that
indicates the number of times after the run that the test should be
repeated,

no - you just have an array of these in the yaml.

> unless one run fails, in which case we stop, and don't repeat?

correct

Revision history for this message

Max Brustkern (nuclearbob) wrote on 2013-04-08:

> On 04/08/2013 09:32 AM, Max Brustkern wrote:
> > So when repeat_count is nonzero, we repeat that many times,
>
> yes
>
> > and the YAML record for each time gets a repeat count number that
> indicates the number of times after the run that the test should be
> repeated,
>
> no - you just have an array of these in the yaml.
Okay, I think I'm confused by the fact that we're calling runner.run(x) for a range of values, but runner is also doing self.repeat_count-=1 and not just relying on the x. Maybe I need to run it to look at the output and understand.
>
> > unless one run fails, in which case we stop, and don't repeat?
>
> correct
I guess this may be out of scope for what you're doing here, but what would be really great for bootspeed and power is if we could retry failed runs instead of stopping on them. That probably requires further additional configuration to set either a maximum number of tries or a timeout, and to set what the behavior on failure should be (i.e., stop, continue, retry.) As an implementation of the option that we already had, this does seem reasonably complete to me, I'm just thinking about possible future enhancements to serve particular use cases.

Revision history for this message

Andy Doan (doanac) wrote on 2013-04-08:

On 04/08/2013 01:09 PM, Max Brustkern wrote:
>> > and the YAML record for each time gets a repeat count number that
>> >indicates the number of times after the run that the test should be
>> >repeated,
>> >
>> >no - you just have an array of these in the yaml.
> Okay, I think I'm confused by the fact that we're calling runner.run(x) for a range of values, but runner is also doing self.repeat_count-=1 and not just relying on the x. Maybe I need to run it to look at the output and understand.

I'll admit this feels a little awkward. The thing to keep in mind is
that we have to know the *first* time something is run (ie rerun =
False) and also how many times to run it. So you need two variables. I'm
using "iteration" to let us know which run we are doing and, if its 0
know rerun=False. "repeat_count" is used to know how how high
"iterations" should go to and gets persisted.

lp:~doanac/utah/client-repeat_count updated on 2013-05-30

855. By Max Brustkern on 2013-04-10

Merged docstring updates

856. By Max Brustkern on 2013-04-10

Adding wait_for_booted change

857. By Max Brustkern on 2013-04-10

Deprecated run scripts

858. By Max Brustkern on 2013-04-10

Fixed LP #1158743

859. By Max Brustkern on 2013-04-10

Fixed issue running nosetests on directory

860. By Max Brustkern on 2013-04-10

Added docstring to setup file

861. By Max Brustkern on 2013-04-11

Fixing call to sshcheck that doesn't match function signature

862. By Max Brustkern on 2013-04-16

Merged iso squashfs validation update

863. By Javier Collado on 2013-04-17

Merged documentation string fixes

Source branch: lp:~javier.collado/utah/documentation_fixes

864. By Javier Collado on 2013-04-17

Merged changes to validate master runlist before provisioning (LP: #1082087)

Source branch: lp:~javier.collado/utah/bug1082087

865. By Javier Collado on 2013-04-18

Fix broken build

The package build is broken because a weird exception:
RuntimeError: sys.path must be a list of directory names

Looking in python source code I see this change:
http://hg.python.org/cpython/rev/c9bb16b7d148

that indeed changes what it was an ImportError to a RuntimeError. However, it's
not clear why PyList_Check(path) is failing because I'm pretty sure that
sys.path is a list (I even tried to filter it with os.path.isdir). Hence, I
guess that path in that code isn't really sys.path under some circumstances.

Anyway, catching that exception and handling it the same way as ImportError
works fine.

866. By Javier Collado on 2013-04-19

Merged changes to use socket timeout in SSH commands instead of SIGALRM (LP: #1169510)

Source branch: lp:~javier.collado/utah/bug1169510

867. By Javier Collado on 2013-04-19

Merged changes to make rsyslog timeout error message clearer (LP: #1169846)

Source branch: lp:~javier.collado/utah/bug1169846

868. By Javier Collado on 2013-04-19

Merged changes to choose battery implementation for a test run

Source branch: lp:~doanac/utah/pluggable-battery

869. By Javier Collado on 2013-04-19

Merged changes to write to log UTAH version as soon as possible (LP: #1152216)

Source branch: lp:~javier.collado/utah/bug1152216

870. By Max Brustkern on 2013-04-19

Merged client rsyslog code

871. By Max Brustkern on 2013-04-19

Added UEFI tests to image validation

872. By Javier Collado on 2013-04-22

Merged changes to verify UTAHTimeout exceptions in rsyslog module

Source branch: lp:~javier.collado/utah/bug1169846-test-case

873. By Javier Collado on 2013-04-24

Merged chnages to cleanup server code

Source branch: lp:~doanac/utah/server-cleanups

874. By Javier Collado on 2013-04-24

Merged changes to cleanup utah.run code

Source branch: lp:~doanac/utah/run-cleanups

875. By Max Brustkern on 2013-04-24

Merged reduced exception catching

876. By Andy Doan on 2013-04-25

uuid_check requires ssh so "self.provisioned" must be True

This call was moved into provisioning.py where its a litle
easier to manage it in conjunction with the state the machine
is in. This now means vm's will do the check as well, but that
should be harmless.

877. By Javier Collado on 2013-04-26