Code review comment for lp:~doanac/ubuntu-ci-services-itself/webui-status

Revision history for this message
Andy Doan (doanac) wrote :

On 03/04/2014 04:59 AM, Evan Dandrea wrote:
> Was http://yuilibrary.com/yui/docs/datatable/ not a good fit here?

We don't have a consistent set of values coming back. So I was basically
just dumping the dictionary that comes back. I'm sure someone with
DataTables knowledge (which josepht has) could help me here.

As an example we'll get data back like this:

  = ppa-django/0
  {
   'launchpad_configured': true,
   'total ppas': 4,
   'available ppas': 1
  }

= bsb-restish/0
{
   'rabbit_configured': true,
}

I think this brings up 2 orthogonal decisions:

1) display strategy: should we use something more professional like
DataTables. And if so, should we do it in this MP? I'd say, use
DataTables, but convert in a follow-on MP. No strong opininion

2) data strategy: Maybe we should try and get these "json status
providers" to send status back in a more understood format that the
webui could provide more intelligent display on. I think "yes" for this,
and its probably not that hard. We could change the format to something
like:

  = ppa-django/0
  [
   {
     'label': 'launchpad_configured',
     'value': true,
     'status': 'PASS'
   },
   {
     'label': 'total ppas',
     'value': 4,
     'status': 'WARNING'
   },
   {
     'label': 'available ppas',
     'value': 0,
     'status': 'ERROR'
   }
  ]

is this worth shooting for in phase0?

« Back to merge proposal